diff --git a/dasharo-compatibility/dasharo-tools-suite.robot b/dasharo-compatibility/dasharo-tools-suite.robot index 2832024696..7f3c23e103 100644 --- a/dasharo-compatibility/dasharo-tools-suite.robot +++ b/dasharo-compatibility/dasharo-tools-suite.robot @@ -79,11 +79,11 @@ DTS005.001 Flash device from DTS shell by using flashrom works correctly Skip If not ${TESTS_IN_FIRMWARE_SUPPORT} DTS006.001 not supported Skip If not ${DTS_FIRMWARE_FLASHING_SUPPORT} DTS006.001 not supported Power On - Disable Firmware Flashing Prevention Options Boot Dasharo Tools Suite iPXE Enter Shell In DTS Set DUT Response Timeout 320s - Flash Firmware In DTS + Execute Command In Terminal wget -O /tmp/coreboot.rom ${FW_NO_EC_SYNC_DOWNLOAD_LINK} + Flash Via Internal Programmer /tmp/coreboot.rom Power On Make Sure That Network Boot Is Enabled Boot Dasharo Tools Suite iPXE diff --git a/dasharo-compatibility/ec-and-super-IO.robot b/dasharo-compatibility/ec-and-super-IO.robot index 8b7dd40f5e..0ad922685e 100644 --- a/dasharo-compatibility/ec-and-super-IO.robot +++ b/dasharo-compatibility/ec-and-super-IO.robot @@ -284,7 +284,8 @@ ECR022.001 EC sync update with power adapter connected works correctly Boot Dasharo Tools Suite iPXE Enter Shell In DTS Set DUT Response Timeout 320s - Flash Firmware In DTS ${FW_NO_EC_SYNC_DOWNLOAD_LINK} + Execute Command In Terminal wget -O /tmp/coreboot.rom ${FW_NO_EC_SYNC_DOWNLOAD_LINK} + Flash Via Internal Programmer /tmp/coreboot.rom Flash EC Firmware ... ${EC_NO_SYNC_DOWNLOAD_LINK} TOOL=dasharo_ectool Sleep 15s @@ -300,7 +301,6 @@ ECR022.001 EC sync update with power adapter connected works correctly Check Firmware Version ${FW_NO_EC_SYNC_VERSION} Check EC Firmware Version ... EXPECTED_VERSION=${EC_NO_SYNC_VERSION} TOOL=dasharo_ectool - # Flash new fw with ec sync Put File ${FW_FILE} /tmp/coreboot_with_ec.rom scp=ALL ${flash_result}= Execute Command In Terminal @@ -339,7 +339,8 @@ ECR023.001 EC sync doesn't update with power adapter disconnected Boot Dasharo Tools Suite iPXE Enter Shell In DTS Set DUT Response Timeout 320s - Flash Firmware In DTS ${FW_NO_EC_SYNC_DOWNLOAD_LINK} + Execute Command In Terminal wget -O /tmp/coreboot.rom ${FW_NO_EC_SYNC_DOWNLOAD_LINK} + Flash Via Internal Programmer /tmp/coreboot.rom Flash EC Firmware ... ${EC_NO_SYNC_DOWNLOAD_LINK} TOOL=dasharo_ectool Sleep 15s diff --git a/lib/flash.robot b/lib/flash.robot index 7e78fdabf4..059a845288 100644 --- a/lib/flash.robot +++ b/lib/flash.robot @@ -36,7 +36,7 @@ Flash Via Internal Programmer END # If no region is given, flash the whole binary - IF ${region} + IF "${region}" != "${EMPTY}" ${args}= Set Variable -N --ifd -i ${region} ELSE ${args}= Set Variable ${EMPTY}