Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts-lib: rework flashing method #141

Open
filipleple opened this issue Dec 8, 2023 · 3 comments · Fixed by #484
Open

dts-lib: rework flashing method #141

filipleple opened this issue Dec 8, 2023 · 3 comments · Fixed by #484
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@filipleple
Copy link
Member

Test environment version

  • Branch:
  • Commit:

Dasharo version (if applicable)

Dasharo variant (if applicable)

Affected component(s) or functionality (if applicable)

flashing keywords in dts-lib

Brief summary

In lib/dts-lib.robot, there is a keyword called Flash Firmware In DTS for flashing that forces flashing with the internal programmer. It needs to be replaced with the more generic keyword that we already have developed in keys-and-keywords/flashrom.robot.

Additional context

@macpijan
Copy link
Contributor

macpijan commented Jul 16, 2024

@BeataZdunczyk Should be rather easy task. The kwd from dts-lib should be replaced from the one in lib/flash.robot for internal flashing.

We need to locate which test uses this keyword, so we can prove the replacing was successufl.

@wiktormowinski
Copy link
Contributor

wiktormowinski commented Jul 19, 2024

done with the switcheroo: #404

Tests affected by the change:
ECR022.001 - we always skip that one
ECR023.001 - as above
DTS005.001 - qemu skips it, am i doing something wrong or is this one also redundant??

@macpijan
Copy link
Contributor

QEMU does not support flashrom yet, for sure.

It may be true that this particular test case is mostly not used right now.

@JanPrusinowski JanPrusinowski linked a pull request Sep 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants