Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logout vs remove current device behavior #133

Closed
BenjaminOddou opened this issue Aug 1, 2023 · 1 comment · Fixed by #137
Closed

logout vs remove current device behavior #133

BenjaminOddou opened this issue Aug 1, 2023 · 1 comment · Fixed by #137
Assignees
@Mikescops
Labels
bug Something isn't working

Comments

@BenjaminOddou
Copy link

Describe the bug
Maybe it is intendend but I don't understand why the logout command does not remove the device from the current account like it does with dcli devices remove <current-id-device>

To Reproduce
Steps to reproduce the behavior:

  1. dcli devices remove <current-id-device>
  2. Press ⏎ on 'Yes'

The device is removed.

  1. dcli logout
  2. Press ⏎ on 'Yes'

The device is kept in the dcli devices list.

Expected behavior
Same behavior has dcli devices remove <current-id-device>.

Environment (please complete the following information):

  • OS: MacOS Ventura
  • CLI Version 1.9.0
@BenjaminOddou BenjaminOddou added the bug Something isn't working label Aug 1, 2023
@Mikescops
Copy link
Member

That's very valid, I spotted this too and forgot to fill a bug, thx!

@Mikescops Mikescops self-assigned this Aug 2, 2023
Mikescops added a commit that referenced this issue Aug 2, 2023
@Mikescops
Deactivate device upon logout
f70d104 
Fix #133
@Mikescops Mikescops mentioned this issue Aug 2, 2023
Merged
Mikescops added a commit that referenced this issue Aug 2, 2023
@Mikescops
Deactivate device upon logout (#137)
86ac92b 
Fix a legacy behaviour where deactivate device was not yet implemented.
Devices are now deactivated upon logout.

Fix #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mikescops Mikescops

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deactivate device upon logout Dashlane/dashlane-cli
2 participants
@Mikescops @BenjaminOddou