Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka recipe #113

Merged
merged 8 commits into from
Apr 3, 2014
Merged

Kafka recipe #113

merged 8 commits into from
Apr 3, 2014

Conversation

QuentinFra
Copy link
Member

Adding recipes for kafka and kafka.consumer checks. Tested locally with Kitchen tests

is_jmx: true

# Metrics collected by this check. You should not have to modify this.
conf:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file mixes 2-space with 4-space.
YAML is already hard enough to get right with one or the other, let's not mix them in the same file.
We use 2-space everywhere else in this cookbook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, let me correct that immediately

@clofresh
Copy link

clofresh commented Apr 2, 2014

You should commit the kitchen tests too so that people can run them themselves if they need to make changes to the recipe

@miketheman
Copy link
Contributor

The test suite is there, not any tests.

@QuentinFra
Copy link
Member Author

There are only test suites (that's what Carlo was talking about).

Quentin

On Wed, Apr 2, 2014 at 8:23 PM, Mike Fiedler notifications@gh.neting.ccwrote:

The test suite is there, not any tests.

Reply to this email directly or view it on GitHubhttps://github.com//pull/113#issuecomment-39400223
.

@miketheman
Copy link
Contributor

The suites will spin up, deploy the code, but make no assertions about the validity of the state - those tests match the suite name under the test/ directory.

@QuentinFra
Copy link
Member Author

I just wanted to test that there was no coding error in the recipes I made,
so the test suites were good for that.
For the configuration itself, I tested it manually. Isn't that enough? I
don't see many tests for the other integrations...

Quentin

On Thu, Apr 3, 2014 at 10:08 AM, Mike Fiedler notifications@gh.neting.ccwrote:

The suites will spin up, deploy the code, but make no assertions about the
validity of the state - those tests match the suite name under the test/directory.

Reply to this email directly or view it on GitHubhttps://github.com//pull/113#issuecomment-39454964
.

QuentinFra pushed a commit that referenced this pull request Apr 3, 2014
@QuentinFra QuentinFra merged commit b0a0f4d into master Apr 3, 2014
@miketheman miketheman deleted the kafka-recipe branch April 8, 2014 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants