-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka recipe #113
Kafka recipe #113
Conversation
is_jmx: true | ||
|
||
# Metrics collected by this check. You should not have to modify this. | ||
conf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file mixes 2-space with 4-space.
YAML is already hard enough to get right with one or the other, let's not mix them in the same file.
We use 2-space everywhere else in this cookbook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, let me correct that immediately
You should commit the kitchen tests too so that people can run them themselves if they need to make changes to the recipe |
The test suite is there, not any tests. |
There are only test suites (that's what Carlo was talking about). Quentin On Wed, Apr 2, 2014 at 8:23 PM, Mike Fiedler notifications@gh.neting.ccwrote:
|
The suites will spin up, deploy the code, but make no assertions about the validity of the state - those tests match the suite name under the |
I just wanted to test that there was no coding error in the recipes I made, Quentin On Thu, Apr 3, 2014 at 10:08 AM, Mike Fiedler notifications@gh.neting.ccwrote:
|
Adding recipes for kafka and kafka.consumer checks. Tested locally with Kitchen tests