New http_check recipe+template #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the Travis build error. |
|
@miketheman I much prefer your new style of YAML building using the Ruby data structure. If the PR from @mtougeron is what you want to roll with, you won't hurt my feelings but we (Revinate) definitely love your new style of config and would prefer to use it. |
|
@chrissnell I'm a big fan as well - as you can see, there's a comment on that one. I guess "whomever can get the code & tests into place first" wins? /cc: @mtougeron |
|
ready... set... race!! haha. but in all seriousness, I'm updating PR 177 now. |
|
You want TESTS? I think @mtougeron is going to win this one. :) |
|
Thanks for bearing with me - I rebased and reordered a touch, but we're not merged to master along with the other changesets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new recipe and template for http_check. Template uses the Ruby->JSON->YAML data structure conversion a la the JMX check recipe.