New NTP recipe #182
Closed
New NTP recipe #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Any chance of some tests? |
|
Hey @chrissnell , Getting back around to this one, I think it looks good, however the Agent team has actually determined that this is one of those checks that should be enabled by default. See DataDog/dd-agent#1433 for more. This should be making it into the 5.3.0 release in a few weeks, so I'm reluctant to add this to the mix right now - rather once 5.3.0 comes out, it's on by default for anyone. How does that sound to you? |
|
Hi @chrissnell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recipe for the NTP check. Uses the new style Ruby->JSON->YAML configuration translation.