[elastic] Add config flags for shard level metrics #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING: Since these changes will only be shipped with the 5.5 release of the Agent it might be better to wait for the release before merging that. |
|
@elafarge Can you add some docs to the example? https://github.com/DataDog/chef-datadog/blob/etienne/add-new-es-flags/recipes/elasticsearch.rb#L14-L17 |
elafarge
force-pushed
the
etienne/add-new-es-flags
branch
from
8d918bd to
a2f8033
Compare
|
Done @miketheman ! I squashed my changes with the previous commit (I'm not a big fan of |
|
@elafarge Thanks! You might want to address the failures before we merge this. |
Tested with test-kitchen.
elafarge
force-pushed
the
etienne/add-new-es-flags
branch
from
a2f8033 to
0da4fef
Compare
|
Sorry about that @miketheman , I did this edit on a Windows machine where I didn't have my VIM hooks setup :/ We're finally green now :) |
|
Thanks @elafarge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with test-kitchen.