[why-run] Skip dd-handler recipe in why-run mode #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running in why-run mode fails when the chef-handler-datadog gem is not installed because of the `require 'chef/handler/datadog'` line, so we skip the entire recipe in why-run mode. Upgrading chef_handler to v1.2 (Chef>=12) will allow us to remove that `require` and unskip the recipe in why-run mode. See #118
miketheman
added a commit
that referenced
this pull request
Oct 15, 2015
[why-run] Skip dd-handler recipe in why-run mode
|
Thanks @olivielpeau ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running in why-run mode fails when the chef-handler-datadog gem is not
installed because of the
require 'chef/handler/datadog'line, so weskip the entire recipe in why-run mode.
Upgrading chef_handler to v1.2 (Chef>=12) will allow us to remove that
requireand unskip the recipe in why-run mode.See #118