Add attributes for package download retries options #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/implement-retries
branch
4 times, most recently
from
26ca6f6
to
b0bfe45
Compare
olivielpeau
suggested changes
Jan 6, 2017
| @@ -28,10 +28,15 @@ | |||
| dd_agent_msi = dd_agent_version ? "ddagent-cli-#{dd_agent_version}.msi" : 'ddagent-cli.msi' | |||
| temp_file = ::File.join(Chef::Config[:file_cache_path], 'ddagent-cli.msi') | |||
|
|
|||
| package_retries = node['datadog']['agent_package_retries'] | |||
| package_retry_delay = node['agent_package_retry_delay'] | |||
There was a problem hiding this comment.
Actually missed this: should be node['datadog']['agent_package_retry_delay']
Reminds me that I'd appreciate a few simple spec tests on this :)
Allow users to specify the retries/retry_delay options of the package resource on Linux, remote_file on Windows with an attribute.
degemer
force-pushed
the
quentin/implement-retries
branch
from
b0bfe45
to
d40aefe
Compare
olivielpeau
approved these changes
Jan 10, 2017
degemer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify the retries/retry_delay options of the package
resource with an attribute.
Fix #320