Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding mesos #152

Closed
wants to merge 2 commits into from
Closed

adding mesos #152

wants to merge 2 commits into from

Conversation

JohnFiedler
Copy link

Adding mesos yaml and recipe per datadog instruction https://app.datadoghq.com/account/settings#integrations/mesos

@miketheman
Copy link
Contributor

Good stuff for the first round.
The default config for mesos includes an init_config parameter for the default timeout. See https://github.com/DataDog/dd-agent/blob/a995fa2aad5137a57877532367c7d55dcbb56fd0/conf.d/mesos.yaml.example#L2-L3
as well as https://github.com/DataDog/dd-agent/blob/a995fa2aad5137a57877532367c7d55dcbb56fd0/checks.d/mesos.py#L17-L18

This allows both a default_timeout to be set globally, as well as allowing a timeout parameter to be added to the individual instance. Can you add the instance-level timeout?

@miketheman miketheman modified the milestone: Next minor Nov 13, 2014
@miketheman miketheman removed this from the Next minor milestone Dec 31, 2014
@DorianZaccaria DorianZaccaria mentioned this pull request Apr 16, 2015
Merged
@miketheman
Copy link
Contributor

Hey @JohnFiedler @ Thanks for taking the time, we merged in #200 which implements this instead.

@miketheman miketheman closed this Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnFiedler @miketheman