Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quikstart datadog_integration_api_call_v2.yaml parameters were updated but the custom resource itself does not support update #102

Closed
vilikin opened this issue Apr 29, 2024 · 7 comments

Comments

@vilikin
Copy link

vilikin commented Apr 29, 2024

Expected Behavior

I would have expected datadog_integration_api_call_v2.yaml to not require updates, but now our stack is requiring this resource to be updated because the parameters were changed in this commit.

Additionally, it was made in the same commit to not allow updates at all, but to fail on them instead of being a silent no-op like previously. So now our pipelines are stuck as the stack would need to be updated, but it does not support updates.

I would expect such bigger changes to be applied in a new version of the template. And I fail to understand the rationale behind the change: requiring update but not allowing update at the same time? Could you elaborate on the rationale behind the change and how customer's are expected to handle this situation? @sabiurr

Actual Behavior

Stack requires update because of changed parameters, but does not support update.

Steps to Reproduce the Problem

  1. Deploy previous version of a stack based on datadog_integration_api_call_v2.yaml
  2. Try to update the stack (pulling the latest version of the file)
  3. See it fail because it does not support update

Specifications

  • Datadog CloudFormation template version: datadog_integration_api_call_v2.yaml

Stacktrace

Update not supported, no operation performed.
@andyshinn
Copy link

Noticing this as well. I raised #86 related to this as an ask to get stuff versioned in some way that we can pull templates that don't get updated from under our noses.

@JustinLiang90
Copy link

Noticed as well - Here is the PR introducing it. 98896d2

Screenshot 2024-05-05 at 8 55 29 PM

@PPan1215
Copy link

PPan1215 commented May 5, 2024

This is occurring to me too and this is blocking my other parts of CDK stack from updating.

@danny-fairly
Copy link

@sabiurr this is blocking our CDK stack from updating as well. Could you advise? Looks to be related to #107 as well

@ribhavjain
Copy link

This is occurring for us too and we've seen some behavior occasionally deleting our stack entirely (and therefore the integration) after failed updates.

@sabiurr
Copy link
Contributor

sabiurr commented May 8, 2024

This has been reverted #111

Can you try again and see if it works?

@danny-fairly
Copy link

Thanks @sabiurr. It's working again. Note, the stack did have to be deleted and recreated, which means any configurations to the AWS integration via the Datadog UI need to be re-applied.

@sabiurr sabiurr closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants