-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quikstart datadog_integration_api_call_v2.yaml parameters were updated but the custom resource itself does not support update #102
Comments
Noticing this as well. I raised #86 related to this as an ask to get stuff versioned in some way that we can pull templates that don't get updated from under our noses. |
Noticed as well - Here is the PR introducing it. 98896d2 |
This is occurring to me too and this is blocking my other parts of CDK stack from updating. |
This is occurring for us too and we've seen some behavior occasionally deleting our stack entirely (and therefore the integration) after failed updates. |
This has been reverted #111 Can you try again and see if it works? |
Thanks @sabiurr. It's working again. Note, the stack did have to be deleted and recreated, which means any configurations to the AWS integration via the Datadog UI need to be re-applied. |
Expected Behavior
I would have expected
datadog_integration_api_call_v2.yaml
to not require updates, but now our stack is requiring this resource to be updated because the parameters were changed in this commit.Additionally, it was made in the same commit to not allow updates at all, but to fail on them instead of being a silent no-op like previously. So now our pipelines are stuck as the stack would need to be updated, but it does not support updates.
I would expect such bigger changes to be applied in a new version of the template. And I fail to understand the rationale behind the change: requiring update but not allowing update at the same time? Could you elaborate on the rationale behind the change and how customer's are expected to handle this situation? @sabiurr
Actual Behavior
Stack requires update because of changed parameters, but does not support update.
Steps to Reproduce the Problem
datadog_integration_api_call_v2.yaml
Specifications
datadog_integration_api_call_v2.yaml
Stacktrace
The text was updated successfully, but these errors were encountered: