Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics without ECS tags #8551

Open
boh-dan opened this issue Jul 5, 2021 · 2 comments
Open

Metrics without ECS tags #8551

boh-dan opened this issue Jul 5, 2021 · 2 comments

Comments

@boh-dan
Copy link
Contributor

boh-dan commented Jul 5, 2021

The issue happens during the redeploy when old infrastructure is replaced with a new one.
We see a spike in metric that don’t have ECS tags attached which means that they are basically of no use. Although it is a small portion of the metrics that we send overall.

This issue happens along with following error in our log system:
(pkg/tagger/collectors/ecs_extract.go:49 in parseTasks) | container handler func failed: Unable to get resource tags for container : unable to initialize client for metadata v3 API: "docker container " not found.
Our infrastructure is using datadog/agent-dev:clamoriniere-7-29-x-high-cpu-py3-jmx agent image.
We am suspecting that during the redeploy aws introspection returns docker container with empty id.

@sgnn7 sgnn7 added this to the Triage milestone Jul 7, 2021
@danbf
Copy link

danbf commented Jul 12, 2021

@boh-dan this might not be your problem, but we found that during deploys any tags that were gained via auto-discovery would have a drop-out. basically the metrics would come in, but without the normal tagging due to auto-discovery ramping up. our solution was to setup the tags in the datadog config on startup rather then use auto-discovery. we were running the datadog agent locally on the machines at that point, not via a daemonset, but it probably applies to a daemonset datadog agent and auto-discovery.

on our ecs ec2 nodes we set it via the user-data scripts with a line like this:

echo "tags: ecs_cluster:${cluster}, role:ecs" >>/etc/dd-agent/datadog.conf

this shows our tagged requests before and after hard coding the tags:

Screen Shot 2021-07-12 at 5 00 30 PM

@kaitlavs
Copy link
Contributor

Hey @boh-dan. Can you please open a support ticket with our support team so we can investigate this further? We would need a flare from the agent when this behavior is occurring. Feel free to reference this github issue in the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants