Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use device_blacklist for win32 disk checks #1008

Closed
jmoiron opened this issue Jun 27, 2014 · 5 comments
Closed

use device_blacklist for win32 disk checks #1008

jmoiron opened this issue Jun 27, 2014 · 5 comments
Assignees
@bunelr
Labels
3 - Done checks windows
Milestone
5.0

Comments

@jmoiron
Copy link
Contributor

jmoiron commented Jun 27, 2014

The disk checks in checks/system/unix.py use the agent config device_blacklist_re to filter out disks that are not to be checked, but those in checks/system/win32.py do not.
@bunelr bunelr self-assigned this Jul 7, 2014
@remh
Copy link
Contributor

remh commented Jul 10, 2014

@bunelr what's the status of this ? Any ETA ?

@remh remh added this to the 5.0 milestone Jul 10, 2014
@bunelr
Copy link
Contributor

bunelr commented Jul 11, 2014

Got it in a branch here a73faa3 but I'm still working on getting the agent to build on windows in order to test it.

@bunelr bunelr mentioned this issue Jul 17, 2014
Merged
@remh
Copy link
Contributor

remh commented Jul 17, 2014

Got merged #1037

It will be part of the next release of the agent.

@remh remh added the 3 - Done label Jul 17, 2014
@nslocomoives
Copy link

can you confirm the version of agent that will include this fix?

*** I think ive got it lol 5.0.0

@bunelr bunelr closed this as completed Jul 22, 2014
@bunelr
Copy link
Contributor

bunelr commented Jul 22, 2014

Hi @nslocomoives ,

Yes, it will be released with the agent version 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bunelr bunelr

Labels
3 - Done checks windows
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
4 participants
@jmoiron @remh @bunelr @nslocomoives