Fix posture check when several versions of postgres #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tmichelet
commented
Jul 16, 2014
tmichelet
commented
- don't update self.DB_METRICS, use a new dict instead
- don't update self.DB_METRICS, use a new dict instead
| else: | ||
| self.instance_metrics[key] = self.COMMON_METRICS.items() | ||
| metrics = self.instance_metrics.get(key) | ||
| return metrics |
There was a problem hiding this comment.
This will return a list, not a dictionary. The rest of the code won't work with that.
instead of lists
| if self._is_9_2_or_above(key, db): | ||
| self.instance_metrics[key] = dict(self.COMMON_METRICS.items() + self.NEWER_92_METRICS.items()) | ||
| else: | ||
| self.instance_metrics[key] = dict(self.COMMON_METRICS.items()) |
There was a problem hiding this comment.
You can just do
self.instance_metrics[key] = dict(self.COMMON_METRICS)
|
Thanks! |
tmichelet
added a commit
that referenced
this pull request
Jul 16, 2014
Fix posture check when several versions of postgres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.