[snmp] configuration option to ignore non-increasing OIDs #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoCavaille
changed the title
| if init_config is not None: | ||
| mibs_path = init_config.get("mibs_folder") | ||
| SnmpCheck.create_command_generator(mibs_path) | ||
| ignore_nonincreasing_oid = init_config.get("ignore_nonincreasing_oid", False) |
There was a problem hiding this comment.
You may want to cast this properly into a boolean value, I don't know how pysnmp behaves with that (it probably tests the truth value). If the config says True this will be equal to the string "True" , there is a _is_affirmative function in config you can use.
The worst case being bool("False") == True
LeoCavaille
force-pushed
the
snmp_ignore_increasing_oids
branch
from
3e4aabb
to
767211f
Compare
LeoCavaille
force-pushed
the
snmp_ignore_increasing_oids
branch
from
767211f
to
2ff9966
Compare
LeoCavaille
added a commit
that referenced
this pull request
Jan 14, 2015
[snmp] configuration option to ignore non-increasing OIDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration option to walk non-increasing OIDs. Fixes #1231.