[docker] Filter events #1285

LotharSee · 2015-01-08T15:16:08Z

Some improvements around Docker containers filtering.

Filters also apply to events. Fix [docker] container filters do not work with events #1234
Performance improvements around filtering and regex
Fix the logic of our rules: what we were explaining in the documentation (the docker.yaml.example) wasn't matching the real behavior. Fix the code to make it matches.
Clarify the explanations in the example config.

remh · 2015-01-09T21:17:24Z

checks.d/docker.py

        # Aggregate events, one per image. Put newer events first.
        events = defaultdict(list)
        for event in api_events:
+            # Skip events related to filtered containers
+            if event['id'] in skipped_container_ids:
+                continue


nitpick but let's log something in debug here.

remh · 2015-01-09T21:23:49Z

Looks great besides the nitpicks!

[docker] Filter events

LotharSee added 4 commits January 7, 2015 13:53

Docker tag filter also apply to events

8c120e5

Fix docker filter rules mecanism

8c04813

Compile Docker filters regex to be faster

b80500d

Improve docker.yaml example

b1415b2

LeoCavaille added this to the 5.2.0 milestone Jan 9, 2015

LeoCavaille added checks feature labels Jan 9, 2015

LeoCavaille changed the title ~~Filter docker events~~ [docker] Filter events Jan 9, 2015

remh self-assigned this Jan 9, 2015

remh reviewed Jan 9, 2015
View reviewed changes

LotharSee added 2 commits January 9, 2015 16:26

Add debug log around Docker container exclusion

376cbcb

Minor code style change

c4566d4

remh added a commit that referenced this pull request Jan 13, 2015

Merge pull request #1285 from DataDog/filter-docker-events

7455d63

[docker] Filter events

remh merged commit 7455d63 into master Jan 13, 2015

remh deleted the filter-docker-events branch March 23, 2015 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docker] Filter events #1285

[docker] Filter events #1285

LotharSee commented Jan 8, 2015

remh Jan 9, 2015

remh commented Jan 9, 2015

[docker] Filter events #1285

[docker] Filter events #1285

Conversation

LotharSee commented Jan 8, 2015

remh Jan 9, 2015

Choose a reason for hiding this comment

remh commented Jan 9, 2015