[varnish] fix varnishadm subp call with sudo
#1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling subprocess with an argv-like array, argv[0] needs to be the program to execute and not a sequence of programs like `sudo someprogram`. Otherwise this results in: `OSError: [Errno 2] No such file or directory` when trying to find the `sudo someprogram` executable in the PATH.
|
looks good to me |
LeoCavaille
added a commit
that referenced
this pull request
Feb 20, 2015
[varnish] fix `varnishadm` subp call with sudo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling subprocess with an argv-like array, argv[0] needs to
be the program to execute and not a sequence of programs like
sudo someprogram.Otherwise this results in:
OSError: [Errno 2] No such file or directorywhen trying to findthe
sudo someprogramexecutable in the PATH.