Switch http libraries used in checks to requests #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| v = headers['server'] | ||
| try: | ||
| version = int(v.split('/')[1][0]) | ||
| except Exception, e: |
There was a problem hiding this comment.
or
version = int(headers.get('server').split('/')[1][0])None will raise an exception and you get Unknown too?
There was a problem hiding this comment.
or better 🏭 match this against a regex? 🌟
|
Thanks for doing this refactoring, this is awesome. |
* Fix #1196 * Fix #1398 Along with the self contained agent (pyopenssl etc) it will support SNI. See https://github.com/kennethreitz/requests/issues/749 for more information
remh
added a commit
that referenced
this pull request
Feb 27, 2015
Switch http libraries used in checks to requests
|
BIM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Along with the self contained agent (pyopenssl etc) it will support SNI.
See https://github.com/kennethreitz/requests/issues/749 for more
information