Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Proxy Settings return a string instead of an integer for port #1414

Closed
sethrosenblum opened this issue Mar 6, 2015 · 0 comments · Fixed by #1416
Closed

System Proxy Settings return a string instead of an integer for port #1414

sethrosenblum opened this issue Mar 6, 2015 · 0 comments · Fixed by #1416
Assignees
Labels
Milestone

Comments

@sethrosenblum
Copy link
Contributor

When we pull system proxy settings from urllib we end up with this error:

Traceback (most recent call last):
  File "transaction.pyc", line 190, in flush_next
  File "ddagent.pyc", line 272, in flush
  File "tornado\httpclient.pyc", line 206, in fetch
  File "tornado\curl_httpclient.pyc", line 95, in fetch_impl
  File "tornado\curl_httpclient.pyc", line 233, in _process_queue
  File "tornado\curl_httpclient.pyc", line 358, in _curl_setup_request
TypeError: strings are not supported for this option

this is because the proxy port is being set to a string, which tornado doesn't accept:

https://github.com/DataDog/dd-agent/blob/master/config.py#L606-L608

@sethrosenblum sethrosenblum changed the title System Proxy Settings return a string instead of an integer System Proxy Settings return a string instead of an integer for port Mar 6, 2015
@yannmh yannmh self-assigned this Mar 6, 2015
@yannmh yannmh added the bugfix label Mar 6, 2015
@yannmh yannmh added this to the 5.3.0 milestone Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants