[kafka] upgraded jmx keys for >= 0.8.2 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #1424 |
[skip ci] kafka updated their bean names. See the documentation: http://kafka.apache.org/082/documentation.html#monitoring http://kafka.apache.org/081/documentation.html#monitoring This won't work on older Kafka version so we added a warning to link back to the old Kafka sample file if needed [leo@datadoghq.com] Rebased on master and reindented + added warning
LeoCavaille
force-pushed
the
leo/kafka082
branch
from
cdd0dcb
to
5e7dbc7
Compare
|
Do you want to get rid of the single quote ? They are not needed anymore. |
remh
added a commit
that referenced
this pull request
Mar 18, 2015
[kafka] upgraded jmx keys for >= 0.8.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka updated their bean names.
See
https://issues.apache.org/jira/browse/KAFKA-1481
This won't work on older Kafka version so we added a warning
to link back to the old Kafka sample file if needed
[leo@datadoghq.com] Rebased on master and reindented
Link to
beanson a fresh install of 0.8.2 locally: http://paste.cavaille.net/?8f6a17732af85955#WNlLjIh3nzet2yjJIaQ9Z0/ufazYZTTcvG+732EzOJA=And 0.8.1 http://paste.cavaille.net/?b937f059b8dd75e2#NWRRO0TqNDwm/ElRPXK5hDrQIOTbCKdEsfiTwjtWMJ8=