[flare] add stderr of commands #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| choice = raw_input('Are you sure you want to continue [y/N]? ').lower() | ||
| if choice not in ['yes', 'y']: | ||
| choice = raw_input('Are you sure you want to continue [y/N]? ') | ||
| if "".join(choice.lower().split()) not in ['yes', 'y']: |
There was a problem hiding this comment.
What do you think of choice.strip().lower() ?
There was a problem hiding this comment.
I chose this version for this 🔨 :
In [1]: ' y e s'.strip().lower()
Out[1]: 'y e s'
In [2]: ''.join(' y e s'.lower().split())
Out[2]: 'yes'But I agree, it doesn't really make sense, I will change both of them.
There was a problem hiding this comment.
I'd say if someone typed y e s he probably had one too many 🍻 and need to hold off sending his logs 😉
Also: - check if files are readable before trying to add them to the tarfile. - remove whitespaces from input before checking for yes/no.
When launching external commands that import other python modules they might affect our logging handlers and interfere with them. This resets them after the call and ensure we keep the same.
degemer
force-pushed
the
quentin/improve-flare
branch
from
04039ec
to
1f3d519
Compare
|
Thanks for the review and the fix @LeoCavaille ! (tested and it works great) |
|
Travis ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
tarfile.