[kafka_consumer] add timeout for zk/kafka connections #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice thanks1 |
| init_config.get('zk_timeout', DEFAULT_ZK_TIMEOUT)) | ||
| self.kafka_timeout = int( | ||
| init_config.get('kafka_timeout', DEFAULT_KAFKA_TIMEOUT)) | ||
|
|
There was a problem hiding this comment.
You forgot the AgentCheck.__init__(self, name, init_config, agentConfig, instances=instances).
There was a problem hiding this comment.
Wow good catch! 👍 Pushed a fix.
LeoCavaille
force-pushed
the
leo/kafkatimeout
branch
from
d068d46
to
39ccb02
Compare
|
Nice improvement ! 👍 |
Because the default timeouts are pretty high in the kafka-python and kazoo library (resp. 120s and 10s), we put them at a much lower threshold (5s) for the default cases and offer a way to override in the YAML init_config section. Fixes #1589.
LeoCavaille
force-pushed
the
leo/kafkatimeout
branch
from
39ccb02
to
ce85591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the default timeouts are pretty high in the kafka-python and
kazoo library (resp. 120s and 10s), we put them at a much lower
threshold (5s) for the default cases and offer a way to override in the
YAML init_config section.
Fixes #1589.