[core] cast service_checks message to string #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. let's merge once the CI is done. |
As it might break the emitter if the message is not a string. We cannot enforce a good use of service_checks in custom checks (and also sometimes in our own checks, see a874802)
|
CI passed and looks good, merging now. |
LeoCavaille
force-pushed
the
quentin/cast-sc-message-str
branch
from
cd26634
to
4dffc1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it might break the emitter if the message is not a string.
We cannot enforce a good use of service_checks in custom checks (and
also sometimes in our own checks,
see a874802)