[sqlserver] fix collector hangs when a connection is failing #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that mean that as soon as one connection fails, the check won't collect any metrics until a restart of the agent ? |
yannmh
force-pushed
the
yann/fix-sqlserver-hangs
branch
from
2a65268
to
1d461bf
Compare
SQLServer check hangs the collector when a connection is failing. Default timeout is set to 30s, but it is raised multiple times for the same instance: after 120s, collector is restarted by the watchdog and loops back. Solution: cache failing connections at initialization.
yannmh
force-pushed
the
yann/fix-sqlserver-hangs
branch
from
1d461bf
to
c57640f
Compare
|
I added a few changes. If the check initialization ran fine, but the connection is failing afterwards, we'll keep retrying at every check run: the downside is that it slows down the collector since it takes 30seconds to timeout. |
|
Looks good! |
remh
added a commit
that referenced
this pull request
Jun 3, 2015
[sqlserver] fix collector hangs when a connection is failing
|
Changes Unknown when pulling c57640f on yann/fix-sqlserver-hangs into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLServer check hangs the collector when a connection is failing.
Default timeout is set to 30s, but it is raised multiple times for the same instance: after 120s, collector is restarted by the watchdog and loops back.
Solution: cache failing connections.