[jmxfetch][windows] write to file to exit JMXFetch #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/file-to-stop-jmx
branch
2 times, most recently
from
94ed1dd
to
8be0cb0
Compare
|
Nice, can we also clean the exit file when we start jmxfetch to make sure that jmxfetch starts even though the exit file didn't get cleaned properly before ? |
yannmh
force-pushed
the
yann/file-to-stop-jmx
branch
from
8be0cb0
to
a1d5189
Compare
|
Done, thanks @remh ! |
| @@ -230,6 +231,13 @@ def _start(self, path_to_java, java_run_opts, jmx_checks, command, reporter, too | |||
| command, # Name of the command | |||
| ] | |||
|
|
|||
| if get_os() == 'windows': | |||
Order JMXFetch to exit, communicating through a file. Windows only
yannmh
force-pushed
the
yann/file-to-stop-jmx
branch
from
a1d5189
to
77fc6c0
Compare
|
Brought the last changes suggested. Merging |
yannmh
added a commit
that referenced
this pull request
Jun 5, 2015
[jmxfetch][windows] write to file to exit JMXFetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order JMXFetch to exit, communicating through a file. Windows only.
Requires DataDog/jmxfetch#58
Alternative: #1639