[windows] record restarts on a specific timeframe #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def restart(self): | ||
| self._count_restarts += 1 | ||
| if self._count_restarts >= self._MAX_RESTARTS: | ||
| if not self._can_restart(): | ||
| servicemanager.LogInfoMsg( | ||
| "%s reached the limit of restarts. Not restarting..." % self._name) |
There was a problem hiding this comment.
To ease a potential debug, could you add the number of restarts (or tries), max number of restarts, and maybe the time window ?
So something like:
"{0} reached the limit of restarts ({1} tries during the last {3}s (max authorized: {2})). Not restarting...".format(self._name, len(self._restarts), self._restarts[0] - time.time()) ?
yannmh
force-pushed
the
yann/win-max-restart-timeframe
branch
from
1cbaf83
to
203e6ea
Compare
| self._name = name | ||
| self._process = process | ||
| self._count_restarts = 0 | ||
| self._restarts = deque([]) | ||
| self._MAX_RESTARTS = max_restarts |
There was a problem hiding this comment.
I don't really like this way (not your PR, but close), having a "dynamic" constant. Maybe you could instead have a DEFAULT_MAX_RESTARTS = 5, max_restarts=None, and self._max_restarts = max_restarts or self.DEFAULT_MAX_RESTARTS: what do you think ?
|
Nice improvement! |
Drop the global count of restarts in favor of a timeframe based one.
yannmh
force-pushed
the
yann/win-max-restart-timeframe
branch
from
203e6ea
to
49f7cb3
Compare
yannmh
added a commit
that referenced
this pull request
Jun 9, 2015
[windows] record restarts on a specific timeframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the global count of restarts in favor of a timeframe based one.