[GCE] Update hostname to be unique #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tags are either not useful or bad security practices, let's exclude them
The current hostname we use is not unique, if people have several projects with instances with the same name, their hostname will be the same, their tags will be wrong and their metrics will be aggre- gated. This commit fixes that, and adds an option on the config to keep the backward compatibility.
As the hostname isn't available via the GCE API, we need this host alias list to link metrics and tags from the crawler to the agent's
| @@ -43,6 +43,9 @@ api_key: | |||
| # for more information | |||
| # collect_instance_metadata: yes | |||
|
|
|||
| # use unique hostname for GCE hosts. see #1736 | |||
There was a problem hiding this comment.
Let's create a wiki page and add the link
There was a problem hiding this comment.
first pass is done, see https://github.com/DataDog/dd-agent/wiki/Hostname-on-Google-Cloud-Engine
|
@remh link updated, good to merge? |
tmichelet
added a commit
that referenced
this pull request
Jul 30, 2015
[GCE] Update hostname to be unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1736
host_metadata['instance']['hostname']so it's unique"instance_name.project_id"as a host alias