Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisord] selct processes by regexp name match #1747

Merged
merged 2 commits into from
Jul 15, 2015

Conversation

yannmh
Copy link
Member

@yannmh yannmh commented Jul 1, 2015

From @ckrough:
Adds the ability to select processes to monitor by regex name match.

  • Check will monitor processes whose names match the list of regex patterns provided in 'proc_regex'
  • Check will monitor processes whose names exactly match the strings provided in 'proc_names'
  • All processes matching proc_names OR proc_regex filters are monitored.
  • All processes are monitored when no proc_names or proc_regex filters are defined.
  • Sample configuration provides proc_regex examples

My two cents:

  • Rebased on dd-agent 5.4 to solve conflicts.
  • Upgrade integration tests to use AgentCheckTest. Assess full coverage.

Original PR #1375. Thanks a lot @ckrough !

@yannmh yannmh added the checks label Jul 1, 2015
@yannmh yannmh self-assigned this Jul 1, 2015
@yannmh yannmh added this to the 5.5.0 milestone Jul 1, 2015
@yannmh yannmh force-pushed the yann/rebased-supervisor-regexp branch from abf053a to adeff1a Compare July 7, 2015 22:49
@yannmh yannmh force-pushed the yann/rebased-supervisor-regexp branch 2 times, most recently from 9a8d4d5 to 07cfe9e Compare July 8, 2015 14:59
@ckrough
Copy link
Contributor

ckrough commented Jul 9, 2015

Reviewed 3 of 3 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

Adds the ability to select processes to monitor by regex name match.

- Check will monitor processes whose names match the list of regex patterns provided in 'proc_regex'
- Check will monitor processes whose names exactly match the strings provided in 'proc_names'
- All processes matching proc_names OR proc_regex filters are monitored.
- All processes are monitored when no proc_names or proc_regex filters are defined.
- Sample configuration provides proc_regex examples

[yann@datadoghq.com] rebased on dd-agent 5.4 to solve conflicts.
@yannmh yannmh force-pushed the yann/rebased-supervisor-regexp branch from 07cfe9e to 7d54dcf Compare July 10, 2015 14:18
Upgrade integration tests to use AgentCheckTest. Assess full coverage.
@yannmh yannmh force-pushed the yann/rebased-supervisor-regexp branch from 7d54dcf to 2590549 Compare July 14, 2015 21:40
yannmh added a commit that referenced this pull request Jul 15, 2015
[supervisord] selct processes by regexp name match
@yannmh yannmh merged commit 4251314 into master Jul 15, 2015
@yannmh yannmh deleted the yann/rebased-supervisor-regexp branch July 15, 2015 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants