[ec2] Add trailing slash to metadata lists endpoints #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EC2 appears to have changed how you access the collection members of instance metadata--you now need a `/` after each collection to list them: ``` curl http://169.254.169.254/latest/meta-data/iam/security-credentials # nothing curl http://169.254.169.254/latest/meta-data/iam/security-credentials/ ec2-staging-es ``` Rebased: [olivier.vielpeau@datadoghq.com] Merge the trailing slash to `/iam/security-credentials` in iam_params request
Without the trailing slash we get a 301 permanent redirection to the URL with the trailing slash. Add the trailing slash in case the redirection is removed in the future.
|
Is this going to merge soon? This is preventing datadog agent from restarting on any of our ec2 instances. |
|
@dspangen This fix will be merged soon and shipped with v5.5.0 of the agent. The issue shouldn't prevent the agent from restarting though (currently the agent should start fine but with these metadata tags missing). If you have any trouble with the agent not restarting properly feel free to contact support. |
remh
added a commit
that referenced
this pull request
Jul 17, 2015
…ng-slash [ec2] Add trailing slash to metadata lists endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @dspangen for the initial fix.
I've also added the trailing slash to the
public-keysendpoint as it might break in the same way in the future.