Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Check and TCP checks will fail on windows #632

Closed
remh opened this issue Aug 23, 2013 · 5 comments
Closed

HTTP Check and TCP checks will fail on windows #632

remh opened this issue Aug 23, 2013 · 5 comments
Assignees

Comments

@remh
Copy link
Contributor

remh commented Aug 23, 2013

If only on instance is configured because of the hard limit in the number of threads that is reached because windows agent run in separate threads and not in separate processes.

To Fix: Just add more flexibility in the thread limit for windows.

@ghost ghost assigned remh Aug 23, 2013
@conorbranagan
Copy link
Member

Another alternative is to actual spawn multiple processes per daemon instead of threads, using the multiprocessing module, just to keep things closer to the linux agent.

@remh
Copy link
Contributor Author

remh commented Aug 23, 2013

Would need some time as it seems that multi processing windows services is not trivial:
http://stackoverflow.com/questions/10124768/python-pywin32-windows-service-and-multiprocessing

@conorbranagan
Copy link
Member

Is the patch merged into the mainline 2.7? Seems like it should be if the report was 2 years ago. But I can't really tell.

@conorbranagan
Copy link
Member

Looks like it was released in 2.7.2 so as long as we're packaging a version >= 2.7.2 we should be okay.

@remh
Copy link
Contributor Author

remh commented Oct 4, 2013

Going to make a quick fix for this one and file another issue to switch to multiprocessing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants