added tokumx check by cloning and modifying mongo #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leifwalsh
commented
May 6, 2014
leifwalsh
commented
- fixed calculation of replication lag (and in mongo check)
- added opcountersRepl (and in mongo check)
- added tokumx-specific metrics present in tokumx 1.4.2
- added some more replication info
- added some sharding info (could use more in the future)
- changed to MongoClient to keep up with modern pymongo usage
- added db/collection/index stats with tags
- fixed calculation of replication lag (and in mongo check) - added opcountersRepl (and in mongo check) - added tokumx-specific metrics present in tokumx 1.4.2 - added some more replication info - added some sharding info (could use more in the future) - changed to MongoClient to keep up with modern pymongo usage - added db/collection/index stats with tags
|
Thanks a lot @leifwalsh ! We will review really that really soon 👍 |
|
🤘 |
|
actually I have a couple more metrics to add, one second |
|
ok, that's it |
| state of a mongo node""" | ||
|
|
||
| def get_state_description(state): | ||
| if state == 0: return 'Starting Up' |
There was a problem hiding this comment.
You should probably create a dictionary to do that, something like:
STATE_DESCRIPTIONS = {
0: 'Starting Up',
1: 'Primary',
...
}and then you'll be able to do:
status = STATE_DESCRIPTIONS[state]There was a problem hiding this comment.
This was from the mongo checker, I don't really care how it's implemented. We can do it this way if you like.
There was a problem hiding this comment.
Yeah just realized that. It's fine then, i'll fix it, no worries.
Thanks!
(notes from code review in DataDog#933)
|
Thanks @leifwalsh ! |
remh
added a commit
that referenced
this pull request
May 20, 2014
added tokumx check by cloning and modifying mongo
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.