HAProxy: gauge missing statuses with zero #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,10 @@ class Services(object): | |||
| BACKEND = 'BACKEND' | |||
| FRONTEND = 'FRONTEND' | |||
| ALL = (BACKEND, FRONTEND) | |||
| ALL_STATUSES = ( | |||
| 'up', 'up_1/3', 'up_2/3', 'open', 'no_check', 'down', 'down_1/2', | |||
There was a problem hiding this comment.
do not consider up_x/y nor down_x/y
|
|
might want to remove "front-end" from the event name, that's confusing |
|
|
@remh should we default |
|
Do we need to have "HAProxy" in the event title? Seems a bit redundant with the haproxy logo right next to it |
|
good point, I'll remove it |
| # Send the list of data to the metric and event callbacks | ||
| self._process_metrics(data_dict, url) | ||
| if process_events: | ||
| self._process_event(data_dict, url) | ||
| if process_events: |
There was a problem hiding this comment.
yes, I thought that we don't want to have events on aggregates if we use the detail otherwise, and vice versa
There was a problem hiding this comment.
this way:
- use aggregates -> metrics and events for the aggregates
- don't use aggregates -> metrics and events detailed, without the noise of the aggregates
|
Thanks @tmichelet ! Looks like the tests are failing though! Could you investigate and fix ? |
tmichelet
added a commit
that referenced
this pull request
May 19, 2014
HAProxy: gauge missing statuses with zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About count_per_status:
For each service, we currently only gauge the current status of the service.
This means that if the service was previously down and is up again, we are going to gauge(count, [up]) but not gauge(0, [down]).
Since on the UI the missing data is regressed, we can see this kind of bug:
The second chart keeps displaying 2, instead of displaying 0 where the value is missing.
This PR is about solving that, by always gauging each status (either count or 0, depending on the current status).
Pros: avoid these bugs
Cons: more data pushed, charts with only zeros appear
New charts:
