Can I set the environment setting via an environment variable?

[keattang]

This is inherently environment related and not something I'd like to bake into my docker images.

[cgilmour]

Which setting(s) does this refer to?

[keattang]

This one

dd-opentracing-cpp/src/tracer_factory.cpp

Line 93 in ea185e7

// "environment": A string, defaults to "". The environment this trace belongs to.

[cgilmour]

It's usually set on the agent instead of the application that submits traces to the agent.
Either set apm_config.env in the config file, or if running datadog-agent as a container, use the DD_APM_ENV variable.

[keattang]

Ah I see. Unfortunately our agent services multiple different environments so that would not work for us. Can I request this as a feature?

I'm not too familiar with C++ but I could attempt to make a PR. Would there be much more to it that adding a block like this

dd-opentracing-cpp/src/tracer_options.cpp

Line 15 in ea185e7

auto agent_host = std::getenv("DD_AGENT_HOST");

?

[cgilmour]

It'd be a few small changes

• choosing the right name for the env variable
• a block like you linked to
• a small change to an existing test

  dd-opentracing-cpp/test/tracer_options_test.cpp

  Lines 42 to 47 in ea185e7

  	{"DD_PROPAGATION_STYLE_INJECT", "Datadog B3"}},
  	TracerOptions{"host",
  	420,
  	"",
  	"web",
  	"",

• updating the comment to say "Can also be set by ..."

[muenchdo]

We have a similar setup (agent servicing multiple environments), so we would also be very happy to get this feature! :)

[keattang]

I've created this PR #103

[keattang]

@cgilmour Thanks for merging my PR! When do you think it will make it into a release?

[palazzem]

Thanks @keattang for the contribution! we're doing some work around the release process, so that we can target a 1.0. The goal is in having this ready in roughly 2 weeks. In the meantime, @cgilmour can give you extra details to let you use your contribution! Hope it helps!

[keattang]

Cool thanks @palazzem!

[cgilmour]

Hi @keattang, let me know what help you need here.
Right now, if you're checking out v0.4.3 and want to use an unreleased version with your contribution, you can check out the commit instead: 113b7c143bc7b557d75ed790437f1b8f618cc9bb.
Once 1.0.0 is released, then you can switch back to using tags.

Does that work for you?

[keattang]

Thanks @cgilmour sounds good. Do I then just follow the build instructions in the readme?

[cgilmour]

Yes.

Are you currently using one of the pre-built binaries from a release?
If so, there might be extra details - let me know!

[keattang]

Yes, currently using the latest pre-built binary.

[cgilmour]

OK.

If you're using libdd_opentracing.so, then that's built by default.
If you're using libdd_opentracing_plugin.so, then it needs an extra detail: run cmake -DBUILD_PLUGIN=ON .. before running make.

[keattang]

Great, thanks!