From ce7f3a8fcd93fbd2ff85ac2df7988727f9e16225 Mon Sep 17 00:00:00 2001 From: Andrew Lock Date: Thu, 8 Aug 2024 11:16:47 +0100 Subject: [PATCH] Skip the mass transit test to see if it solves flake issues (#5861) ## Summary of changes Skip the mass transit smoke test as it seems to be a cause of a lot of flakiness ## Reason for change We've seen a lot of errors in the `CheckBuildlogsForErr` stage: ``` CheckBuildLogsForErr: 03:08:39 [Error] An error occurred while sending data to the agent at http://127.0.0.1:39573/v0.4/traces. If the error isn't transient, please check https://docs.datadoghq.com/tracing/troubleshooting/connection_errors/?code-lang=dotnet for guidance. System.Net.Http.HttpRequestException: Error while copying content to a stream. ``` These seemed to get a lot worse after we disabled keep-alive, but that's anecdotal. ## Implementation details It's not entirely clear if the problem is just coincidentally related to the MassTransit test (i.e. it's a test ordering process) or if it's actually something about the test. As a check I tried skipping the test in this branch and did 4 full (all TFM) integration tests runs, and didn't see the issue again. It's all still anecdotal, but rather trade off flakiness here. If the problem reappears subsequently, we can look into it again further. ## Test coverage Did 4 full runs, and didn't see the issue again --- .../SmokeTests/ServiceBusMinimalMassTransitTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/SmokeTests/ServiceBusMinimalMassTransitTest.cs b/tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/SmokeTests/ServiceBusMinimalMassTransitTest.cs index 9ef49c1be63b..2741f4a990bf 100644 --- a/tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/SmokeTests/ServiceBusMinimalMassTransitTest.cs +++ b/tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/SmokeTests/ServiceBusMinimalMassTransitTest.cs @@ -18,7 +18,7 @@ public ServiceBusMinimalMassTransitTest(ITestOutputHelper output) AssumeSuccessOnTimeout = true; } - [SkippableFact] + [SkippableFact(Skip = "Testing to see if this solves weird flake issues")] [Trait("Category", "Smoke")] public async Task NoExceptions() {