Fix AWS SQS test snapshots #4913
Conversation
andrewlock
added
area:builds
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 4 occurrences of : - Resource: POST localhost:00000/?/MyAsyncSQSQueue,
+ Resource: POST localhost:00000/,
64 occurrences of : - http.url: http://localhost:00000/000000000000/MyAsyncSQSQueue,
+ http.url: http://localhost:00000/,
4 occurrences of : - Resource: POST localhost:00000/?/MyAsyncSQSQueue2,
+ Resource: POST localhost:00000/,
48 occurrences of : - http.url: http://localhost:00000/000000000000/MyAsyncSQSQueue2,
+ http.url: http://localhost:00000/,
2 occurrences of : - Resource: POST localhost:00000/?/MySyncSQSQueue,
+ Resource: POST localhost:00000/,
32 occurrences of : - http.url: http://localhost:00000/000000000000/MySyncSQSQueue,
+ http.url: http://localhost:00000/,
2 occurrences of : - Resource: POST localhost:00000/?/MySyncSQSQueue2,
+ Resource: POST localhost:00000/,
24 occurrences of : - http.url: http://localhost:00000/000000000000/MySyncSQSQueue2,
+ http.url: http://localhost:00000/,
|
Datadog ReportBranch report: ✅ |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4913) - mean (71ms) : 64, 78
. : milestone, 71,
master - mean (70ms) : 62, 78
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (4913) - mean (990ms) : 966, 1014
. : milestone, 990,
master - mean (998ms) : 982, 1013
. : milestone, 998,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4913) - mean (106ms) : 103, 109
. : milestone, 106,
master - mean (106ms) : 103, 109
. : milestone, 106,
section CallTarget+Inlining+NGEN
This PR (4913) - mean (686ms) : 670, 702
. : milestone, 686,
master - mean (686ms) : 667, 705
. : milestone, 686,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4913) - mean (89ms) : 86, 92
. : milestone, 89,
master - mean (90ms) : 87, 92
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (4913) - mean (661ms) : 636, 686
. : milestone, 661,
master - mean (661ms) : 634, 687
. : milestone, 661,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4913) - mean (189ms) : 186, 192
. : milestone, 189,
master - mean (188ms) : 186, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (4913) - mean (1,133ms) : 1110, 1157
. : milestone, 1133,
master - mean (1,136ms) : 1115, 1157
. : milestone, 1136,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4913) - mean (271ms) : 267, 276
. : milestone, 271,
master - mean (272ms) : 268, 276
. : milestone, 272,
section CallTarget+Inlining+NGEN
This PR (4913) - mean (1,087ms) : 1063, 1110
. : milestone, 1087,
master - mean (1,092ms) : 1066, 1118
. : milestone, 1092,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4913) - mean (261ms) : 256, 265
. : milestone, 261,
master - mean (261ms) : 257, 265
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (4913) - mean (1,056ms) : 1030, 1082
. : milestone, 1056,
master - mean (1,059ms) : 1036, 1081
. : milestone, 1059,
|
andrewlock
force-pushed
the
andrew/bump-aws
branch
from
aa3cd40
to
a28142f
Compare
| => packageVersion switch | ||
| { | ||
| null or "" => ".pre3_7_300", | ||
| { } v when new Version(v) < new Version("3.7.300.6") => ".pre3_7_300", |
There was a problem hiding this comment.
Shouldn't it be 3.7.300.0? You said: AWS SWS 3.7.300.x changed the way requests are made to the backend in the PR desc
| { } v when new Version(v) < new Version("3.7.300.6") => ".pre3_7_300", | |
| { } v when new Version(v) < new Version("3.7.300.0") => ".pre3_7_300", |
There was a problem hiding this comment.
yeah... I know... it's weird right... but it looks like we're already testing 3.7.300.3 already , which is apparently passing. And after this update we'll never test 3.7.300.0-3.7.300.5 so meh 😄 🤷♂️
Summary of changes
AWS SWS 3.7.300.x changed the way requests are made to the backend, which requires updating some snapshots
Reason for change
The AWS integration tests fail on the latest packages without these changes
Implementation details
.pre-3_7_300to the old snapshotshttp.url: http://localhost:00000/000000000000/MyAsyncSQSQueue->http.url: http://localhost:00000http.url: http://localhost:00000/000000000000/MyAsyncSQSQueue2->http.url: http://localhost:00000http.url: http://localhost:00000/000000000000/MySyncSQSQueue->http.url: http://localhost:00000http.url: http://localhost:00000/000000000000/MySyncSQSQueue2->http.url: http://localhost:00000http.requestspans where requiredTest coverage
Should be covered by existing
Other details
I did this in here initially, but I just know the bot is going to overwrite my changes soon 🙄