Sign dd-dotnet.exe that we package in MSI
#4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
area:builds
kevingosse
approved these changes
Nov 30, 2023
lucaspimentel
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
dd-dotnet.exewe generate in GitLabReason for change
We aren't signing it currently, and we should
Implementation details
Ensure we sign the exe in GitLab. It's included both in the MSI and the tracer-home.zip
Test coverage
Ran a manual test and confirmed it worked, and the exe packaged in the MSI is indeed signed.
Other details
We still have outstanding questions about the linux binaries and Datadog.Trace.Bundle...