Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign dd-dotnet.exe that we package in MSI #4939

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Sign dd-dotnet.exe that we package in MSI #4939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tracer/build/_build/Build.Gitlab.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
partial class Build
{
Target SignDlls => _ => _
.Description("Sign the dlls produced by building the Tracer, Profiler, and Monitoring home directory")
.Description("Sign the dlls produced by building the Tracer, Profiler, and Monitoring home directory, as well as the dd-dotnet exes")
.Unlisted()
.Requires(() => IsWin)
.After(BuildTracerHome, BuildProfilerHome, BuildNativeLoader, CreateRootDescriptorsFile)
.After(BuildTracerHome, BuildProfilerHome, BuildNativeLoader, CreateRootDescriptorsFile, BuildDdDotnet, CopyDdDotnet)
.Before(PackNuGet, BuildMsi, ZipMonitoringHome)
.Executes(() =>
{
Expand All @@ -34,7 +34,11 @@ partial class Build
var homeDlls = MonitoringHomeDirectory.GlobFiles("**/Datadog*.dll");
var waf = MonitoringHomeDirectory.GlobFiles("**/ddwaf.dll");

var dlls = homeDlls.Concat(dllsInBin).Concat(waf);
var ddDotnet = MonitoringHomeDirectory.GlobFiles("**/*.exe")
.Concat(ArtifactsDirectory.GlobFiles("**/*.exe"))
.Concat(MonitoringHomeDirectory.GlobFiles("**/dd-dotnet"))
.Concat(ArtifactsDirectory.GlobFiles("**/dd-dotnet"));
var dlls = homeDlls.Concat(dllsInBin).Concat(waf).Concat(ddDotnet);
SignFiles(dlls.ToList());
});

Expand Down
Loading