Clean dangling AgentWriter instances in unit tests #5311

kevingosse · 2024-03-15T12:02:48Z

Summary of changes

Reduce the number of threads used in unit tests by avoiding the creation of AgentWriter when possible, and properly cleaning Tracer instances otherwise.

Reason for change

Our unit tests create many instances of tracers, which in turn create agentWriters. AgentWriter uses a background thread for serialization, which stays alive unless the AgentWriter is properly cleaned up. Because of that, we were leaking many threads.

Before the changes, the unit tests used 120 threads on average with a peak at 160 (tested on my 20-cores machine).
After the changes, the unit tests use 60 threads on average with a peak at 120.

Implementation details

Use TracerHelper whenever possible
Add a TracerHelper overload to use a mock AgentWriter
Return a disposable Tracer to easily clean the resources

datadog-ddstaging · 2024-03-15T12:19:27Z

Datadog Report

Branch report: kevin/tests_threads
Commit report: 18a8da7
Test service: dd-trace-dotnet

✅ 0 Failed, 326805 Passed, 1590 Skipped, 35m 40.96s Wall Time

andrewlock · 2024-03-15T12:18:58Z

tracer/test/Datadog.Trace.TestHelpers/TracerHelper.cs

+            return new ScopedTracer(settings, Mock.Of<IAgentWriter>());
+        }
+
+        public class ScopedTracer : Tracer, IDisposable


Very nice 👍

andrewlock · 2024-03-15T12:19:31Z

tracer/test/Datadog.Trace.TestHelpers/TracerHelper.cs

+        public static ScopedTracer CreateWithFakeAgent(
+            TracerSettings settings = null)
+        {
+            return new ScopedTracer(settings, Mock.Of<IAgentWriter>());


I kinda feel like this should probably be the default in the TracerHelper 🤔

Honestly I'm 50/50 on this one. "agent disabled by default" is the best choice from a performance perspective, but "agent enabled by default" is the path of least surprise.

andrewlock · 2024-03-15T12:22:50Z

tracer/test/Datadog.Trace.TestHelpers/TracerHelper.cs

+            public void Dispose()
+            {
+                TracerManager.ShutdownAsync().GetAwaiter().GetResult();
+            }


Shame we can't use DisposeAsync() because of .NET FX 🙁

Though maybe we can shim it 🤔

andrewlock · 2024-03-15T12:26:13Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5311) - mean (72ms)  : 65, 78
     .   : milestone, 72,
    master - mean (73ms)  : 65, 80
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5311) - mean (1,001ms)  : 980, 1023
     .   : milestone, 1001,
    master - mean (996ms)  : 974, 1017
     .   : milestone, 996,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5311) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 106, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5311) - mean (717ms)  : 699, 736
     .   : milestone, 717,
    master - mean (717ms)  : 695, 739
     .   : milestone, 717,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5311) - mean (95ms)  : 92, 97
     .   : milestone, 95,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5311) - mean (672ms)  : 649, 695
     .   : milestone, 672,
    master - mean (670ms)  : 653, 687
     .   : milestone, 670,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5311) - mean (188ms)  : 183, 192
     .   : milestone, 188,
    master - mean (187ms)  : 183, 191
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5311) - mean (1,080ms)  : 1052, 1108
     .   : milestone, 1080,
    master - mean (1,070ms)  : 1047, 1092
     .   : milestone, 1070,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5311) - mean (273ms)  : 263, 284
     .   : milestone, 273,
    master - mean (270ms)  : 266, 275
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5311) - mean (878ms)  : 850, 906
     .   : milestone, 878,
    master - mean (876ms)  : 854, 898
     .   : milestone, 876,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5311) - mean (260ms)  : 257, 264
     .   : milestone, 260,
    master - mean (259ms)  : 253, 264
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (5311) - mean (855ms)  : 830, 880
     .   : milestone, 855,
    master - mean (858ms)  : 824, 891
     .   : milestone, 858,

andrewlock · 2024-03-15T12:38:45Z

Benchmarks Report for tracer 🐌

Benchmarks for #5311 compared to master:

2 benchmarks are faster, with geometric mean 1.128
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.7μs	47.2ns	267ns	0.022	0.00878	0	7.5 KB
master	`StartStopWithChild`	netcoreapp3.1	10.9μs	57.7ns	311ns	0.0214	0.0107	0	7.6 KB
master	`StartStopWithChild`	net472	17μs	49.6ns	192ns	1.38	0.349	0.116	8.15 KB
#5311	`StartStopWithChild`	net6.0	8.81μs	49.8ns	352ns	0.0173	0.00867	0	7.5 KB
#5311	`StartStopWithChild`	netcoreapp3.1	10.7μs	59.1ns	374ns	0.0256	0.0102	0	7.6 KB
#5311	`StartStopWithChild`	net472	17μs	82.2ns	349ns	1.38	0.357	0.128	8.15 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	462μs	150ns	560ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	616μs	124ns	465ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	810μs	315ns	1.22μs	0.406	3.3 KB
#5311	`WriteAndFlushEnrichedTraces`	net6.0	451μs	250ns	968ns	0	2.7 KB
#5311	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	616μs	258ns	1μs	0	2.7 KB
#5311	`WriteAndFlushEnrichedTraces`	net472	805μs	364ns	1.41μs	0.401	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	169μs	165ns	618ns	0.17	18.33 KB
master	`SendRequest`	netcoreapp3.1	191μs	289ns	1.12μs	0.188	20.49 KB
master	`SendRequest`	net472	0.000468ns	0.000238ns	0.000921ns	0	0 b
#5311	`SendRequest`	net6.0	169μs	125ns	484ns	0.253	18.33 KB
#5311	`SendRequest`	netcoreapp3.1	194μs	431ns	1.67μs	0.192	20.49 KB
#5311	`SendRequest`	net472	0.000198ns	0.000109ns	0.000393ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5311

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.96 KB	41.68 KB	-275 B	-0.66%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	547μs	223ns	864ns	0.541	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	885ns	3.31μs	0.322	0	0	41.96 KB
master	`WriteAndFlushEnrichedTraces`	net472	875μs	2.4μs	8.97μs	8.19	2.59	0.431	53.24 KB
#5311	`WriteAndFlushEnrichedTraces`	net6.0	551μs	639ns	2.47μs	0.543	0	0	41.76 KB
#5311	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	678μs	1.05μs	4.07μs	0.334	0	0	41.68 KB
#5311	`WriteAndFlushEnrichedTraces`	net472	862μs	4.41μs	20.7μs	8.19	2.59	0.431	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.1μs	0.722ns	2.79ns	0.0109	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	1.98ns	7.66ns	0.0102	784 B
master	`ExecuteNonQuery`	net472	1.83μs	0.749ns	2.8ns	0.118	746 B
#5311	`ExecuteNonQuery`	net6.0	1.2μs	0.735ns	2.75ns	0.0108	784 B
#5311	`ExecuteNonQuery`	netcoreapp3.1	1.49μs	1.11ns	4.31ns	0.0105	784 B
#5311	`ExecuteNonQuery`	net472	1.76μs	0.814ns	3.15ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5311

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.128	1,417.77	1,257.44

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.789ns	3.06ns	0.0142	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.532ns	1.99ns	0.0134	1.01 KB
master	`CallElasticsearch`	net472	2.55μs	2.16ns	8.35ns	0.161	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.42μs	0.888ns	3.44ns	0.0142	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.75ns	2.9ns	0.0141	1.06 KB
master	`CallElasticsearchAsync`	net472	2.58μs	1.19ns	4.61ns	0.17	1.08 KB
#5311	`CallElasticsearch`	net6.0	1.24μs	0.625ns	2.34ns	0.014	1.01 KB
#5311	`CallElasticsearch`	netcoreapp3.1	1.71μs	0.688ns	2.48ns	0.0138	1.01 KB
#5311	`CallElasticsearch`	net472	2.6μs	6.35ns	24.6ns	0.161	1.02 KB
#5311	`CallElasticsearchAsync`	net6.0	1.26μs	0.789ns	2.95ns	0.0139	984 B
#5311	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.803ns	3.01ns	0.014	1.06 KB
#5311	`CallElasticsearchAsync`	net472	2.56μs	0.697ns	2.51ns	0.17	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.39μs	0.845ns	3.27ns	0.0131	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	1.38ns	5.15ns	0.0122	928 B
master	`ExecuteAsync`	net472	1.89μs	1.01ns	3.9ns	0.141	891 B
#5311	`ExecuteAsync`	net6.0	1.31μs	1.01ns	3.77ns	0.0132	928 B
#5311	`ExecuteAsync`	netcoreapp3.1	1.76μs	0.693ns	2.59ns	0.0123	928 B
#5311	`ExecuteAsync`	net472	1.92μs	1.09ns	4.07ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.13μs	1.6ns	5.78ns	0.0296	2.16 KB
master	`SendAsync`	netcoreapp3.1	5.16μs	2.69ns	10.1ns	0.0363	2.7 KB
master	`SendAsync`	net472	7.68μs	6.12ns	22.9ns	0.535	3.38 KB
#5311	`SendAsync`	net6.0	4.18μs	1.4ns	5.23ns	0.0293	2.16 KB
#5311	`SendAsync`	netcoreapp3.1	4.87μs	2.06ns	7.69ns	0.0366	2.7 KB
#5311	`SendAsync`	net472	7.9μs	2.32ns	8.7ns	0.534	3.38 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.52μs	0.548ns	1.98ns	0.0231	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.15μs	0.689ns	2.58ns	0.0223	1.65 KB
master	`EnrichedLog`	net472	2.67μs	0.691ns	2.68ns	0.249	1.57 KB
#5311	`EnrichedLog`	net6.0	1.47μs	0.757ns	2.93ns	0.0234	1.65 KB
#5311	`EnrichedLog`	netcoreapp3.1	2.3μs	3.39ns	12.7ns	0.0222	1.65 KB
#5311	`EnrichedLog`	net472	2.55μs	2.11ns	8.17ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	54.2ns	203ns	0.056	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	216ns	838ns	0	0	4.23 KB
master	`EnrichedLog`	net472	147μs	170ns	660ns	0.656	0.219	4.41 KB
#5311	`EnrichedLog`	net6.0	112μs	70.6ns	264ns	0.0568	0	4.23 KB
#5311	`EnrichedLog`	netcoreapp3.1	118μs	134ns	500ns	0	0	4.23 KB
#5311	`EnrichedLog`	net472	147μs	242ns	904ns	0.655	0.218	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.92μs	1.61ns	5.82ns	0.0305	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.33μs	1.09ns	3.78ns	0.0303	2.21 KB
master	`EnrichedLog`	net472	5.01μs	1.48ns	5.32ns	0.32	2.02 KB
#5311	`EnrichedLog`	net6.0	3.04μs	0.738ns	2.66ns	0.0303	2.21 KB
#5311	`EnrichedLog`	netcoreapp3.1	4.13μs	2.65ns	10.3ns	0.0289	2.21 KB
#5311	`EnrichedLog`	net472	4.82μs	2.68ns	10.4ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.45μs	1.67ns	6.49ns	0.0167	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.994ns	3.72ns	0.0159	1.18 KB
master	`SendReceive`	net472	2.15μs	0.835ns	3.24ns	0.187	1.18 KB
#5311	`SendReceive`	net6.0	1.43μs	1.56ns	5.82ns	0.0165	1.18 KB
#5311	`SendReceive`	netcoreapp3.1	1.76μs	2.27ns	8.79ns	0.0158	1.18 KB
#5311	`SendReceive`	net472	2.22μs	1.55ns	6.01ns	0.187	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.74μs	0.848ns	3.29ns	0.0219	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	3.82μs	1.61ns	6.22ns	0.0212	1.6 KB
master	`EnrichedLog`	net472	4.48μs	1.82ns	6.81ns	0.314	1.99 KB
#5311	`EnrichedLog`	net6.0	2.72μs	0.931ns	3.61ns	0.0219	1.55 KB
#5311	`EnrichedLog`	netcoreapp3.1	3.77μs	1.69ns	6.1ns	0.021	1.6 KB
#5311	`EnrichedLog`	net472	4.56μs	2.45ns	8.85ns	0.315	1.99 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5311

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.128	587.69	521.09

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	584ns	0.714ns	2.67ns	0.0077	552 B
master	`StartFinishSpan`	netcoreapp3.1	708ns	1.43ns	5.55ns	0.00759	552 B
master	`StartFinishSpan`	net472	723ns	1.25ns	4.85ns	0.0878	554 B
master	`StartFinishScope`	net6.0	587ns	0.857ns	3.32ns	0.00936	672 B
master	`StartFinishScope`	netcoreapp3.1	897ns	1.63ns	6.09ns	0.00892	672 B
master	`StartFinishScope`	net472	920ns	1.55ns	6.01ns	0.101	634 B
#5311	`StartFinishSpan`	net6.0	540ns	1.15ns	4.45ns	0.00784	552 B
#5311	`StartFinishSpan`	netcoreapp3.1	643ns	1.36ns	5.09ns	0.00751	552 B
#5311	`StartFinishSpan`	net472	736ns	0.997ns	3.86ns	0.0879	554 B
#5311	`StartFinishScope`	net6.0	522ns	0.759ns	2.94ns	0.00944	672 B
#5311	`StartFinishScope`	netcoreapp3.1	812ns	1.12ns	4.34ns	0.00898	672 B
#5311	`StartFinishScope`	net472	922ns	1.37ns	5.31ns	0.101	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	619ns	1.34ns	5.19ns	0.00951	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	961ns	1.66ns	6.43ns	0.00884	672 B
master	`RunOnMethodBegin`	net472	1.06μs	2.01ns	7.77ns	0.101	634 B
#5311	`RunOnMethodBegin`	net6.0	685ns	1.11ns	4.31ns	0.00945	672 B
#5311	`RunOnMethodBegin`	netcoreapp3.1	995ns	1.33ns	4.98ns	0.0089	672 B
#5311	`RunOnMethodBegin`	net472	994ns	1.56ns	6.05ns	0.1	634 B

andrewlock · 2024-03-15T12:58:43Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5311) (11.004M)   : 0, 11004238
    master (11.325M)   : 0, 11324667
    benchmarks/2.9.0 (11.277M)   : 0, 11277254

    section Automatic
    This PR (5311) (7.664M)   : 0, 7664197
    master (7.785M)   : 0, 7785071
    benchmarks/2.9.0 (7.986M)   : 0, 7985594

    section Trace stats
    This PR (5311) (8.153M)   : 0, 8152837
    master (8.030M)   : 0, 8029574

    section Manual
    This PR (5311) (9.700M)   : 0, 9699591
    master (9.790M)   : 0, 9790118

    section Manual + Automatic
    This PR (5311) (7.360M)   : 0, 7360183
    master (7.255M)   : 0, 7254615

    section Version Conflict
    This PR (5311) (6.594M)   : 0, 6593572
    master (6.649M)   : 0, 6649451

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5311) (9.624M)   : 0, 9624477
    master (9.499M)   : 0, 9498796
    benchmarks/2.9.0 (9.656M)   : 0, 9655801

    section Automatic
    This PR (5311) (6.658M)   : 0, 6657624
    master (6.572M)   : 0, 6571504

    section Trace stats
    This PR (5311) (6.767M)   : 0, 6767321
    master (6.781M)   : 0, 6781384

    section Manual
    This PR (5311) (8.355M)   : 0, 8354906
    master (7.963M)   : 0, 7962540

    section Manual + Automatic
    This PR (5311) (6.053M)   : 0, 6052742
    master (6.132M)   : 0, 6132125

    section Version Conflict
    This PR (5311) (5.771M)   : 0, 5771194
    master (5.616M)   : 0, 5616216

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5311) (9.864M)   : 0, 9864200
    master (9.851M)   : 0, 9850836
    benchmarks/2.9.0 (9.962M)   : 0, 9961782

    section Automatic
    This PR (5311) (7.120M)   : 0, 7120041
    master (7.061M)   : 0, 7060782
    benchmarks/2.9.0 (7.328M)   : 0, 7328264

    section Trace stats
    This PR (5311) (7.444M)   : 0, 7443596
    master (7.367M)   : 0, 7366991

    section Manual
    This PR (5311) (8.867M)   : 0, 8866868
    master (8.739M)   : 0, 8739132

    section Manual + Automatic
    This PR (5311) (6.887M)   : 0, 6887133
    master (6.785M)   : 0, 6785188

    section Version Conflict
    This PR (5311) (6.191M)   : 0, 6190840
    master (6.306M)   : 0, 6305644

tracer/test/Datadog.Trace.TestHelpers/TracerHelper.cs

Clean dangling AgentWriter instances in unit tests

1af3958

kevingosse requested a review from a team as a code owner March 15, 2024 12:02

github-actions bot added the area:tests unit tests, integration tests label Mar 15, 2024

andrewlock approved these changes Mar 15, 2024

View reviewed changes

andrewlock reviewed Mar 15, 2024

View reviewed changes

lucaspimentel reviewed Mar 15, 2024

View reviewed changes

tracer/test/Datadog.Trace.TestHelpers/TracerHelper.cs Outdated Show resolved Hide resolved

Asyncify

18a8da7

lucaspimentel approved these changes Mar 19, 2024

View reviewed changes

kevingosse merged commit abf716f into master Mar 20, 2024
56 checks passed

kevingosse deleted the kevin/tests_threads branch March 20, 2024 10:03

github-actions bot added this to the vNext milestone Mar 20, 2024

andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean dangling AgentWriter instances in unit tests #5311

Clean dangling AgentWriter instances in unit tests #5311

kevingosse commented Mar 15, 2024

datadog-ddstaging bot commented Mar 15, 2024 •

edited

Loading

andrewlock Mar 15, 2024

andrewlock Mar 15, 2024

kevingosse Mar 18, 2024

andrewlock Mar 15, 2024

kevingosse Mar 18, 2024

kevingosse Mar 18, 2024

andrewlock commented Mar 15, 2024 •

edited

Loading

andrewlock commented Mar 15, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5311

Raw results

Raw results

Faster 🎉 in #5311

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5311

Raw results

Raw results

andrewlock commented Mar 15, 2024 •

edited

Loading

Clean dangling AgentWriter instances in unit tests #5311

Clean dangling AgentWriter instances in unit tests #5311

Conversation

kevingosse commented Mar 15, 2024

Summary of changes

Reason for change

Implementation details

datadog-ddstaging bot commented Mar 15, 2024 • edited Loading

Datadog Report

andrewlock Mar 15, 2024

Choose a reason for hiding this comment

andrewlock Mar 15, 2024

Choose a reason for hiding this comment

kevingosse Mar 18, 2024

Choose a reason for hiding this comment

andrewlock Mar 15, 2024

Choose a reason for hiding this comment

kevingosse Mar 18, 2024

Choose a reason for hiding this comment

kevingosse Mar 18, 2024

Choose a reason for hiding this comment

andrewlock commented Mar 15, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Mar 15, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5311

Raw results

Raw results

Faster 🎉 in #5311

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5311

Raw results

Raw results

andrewlock commented Mar 15, 2024 • edited Loading

Throughput/Crank Report:zap:

datadog-ddstaging bot commented Mar 15, 2024 •

edited

Loading

andrewlock commented Mar 15, 2024 •

edited

Loading

andrewlock commented Mar 15, 2024 •

edited

Loading

andrewlock commented Mar 15, 2024 •

edited

Loading