Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling ASM Throughput Job #5345

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Conversation

link04
Copy link
Contributor

@link04 link04 commented Mar 23, 2024

Summary of changes

Commented out the ASM Throughput Job so that we can collect data on other flaky stages/tests before the quarter ends to try addressing the underlaying issue with less pressure in the incoming Q2 weeks.

@link04 link04 added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Mar 23, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Mar 23, 2024

Datadog Report

Branch report: maximo/testing-with-ultimate-pipeline.yml
Commit report: 96fc5b3
Test service: dd-trace-dotnet

✅ 0 Failed, 328162 Passed, 1582 Skipped, 42m 0.62s Wall Time

@andrewlock
Copy link
Member

andrewlock commented Mar 23, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5345) - mean (74ms)  : 65, 83
     .   : milestone, 74,
    master - mean (76ms)  : 64, 87
     .   : milestone, 76,

    section CallTarget+Inlining+NGEN
    This PR (5345) - mean (1,001ms)  : 974, 1029
     .   : milestone, 1001,
    master - mean (1,002ms)  : 981, 1022
     .   : milestone, 1002,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5345) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (110ms)  : 107, 112
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5345) - mean (713ms)  : 695, 731
     .   : milestone, 713,
    master - mean (718ms)  : 694, 741
     .   : milestone, 718,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5345) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (95ms)  : 91, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5345) - mean (683ms)  : 662, 704
     .   : milestone, 683,
    master - mean (676ms)  : 653, 698
     .   : milestone, 676,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5345) - mean (188ms)  : 184, 191
     .   : milestone, 188,
    master - mean (188ms)  : 184, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5345) - mean (1,075ms)  : 1048, 1103
     .   : milestone, 1075,
    master - mean (1,080ms)  : 1058, 1102
     .   : milestone, 1080,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5345) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5345) - mean (868ms)  : 842, 895
     .   : milestone, 868,
    master - mean (874ms)  : 853, 895
     .   : milestone, 874,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5345) - mean (260ms)  : 255, 265
     .   : milestone, 260,
    master - mean (260ms)  : 254, 265
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5345) - mean (852ms)  : 833, 872
     .   : milestone, 852,
    master - mean (850ms)  : 827, 872
     .   : milestone, 850,

Loading

@andrewlock
Copy link
Member

andrewlock commented Mar 23, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #5345 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.142
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.82μs 45.3ns 217ns 0.0265 0.0132 0 7.51 KB
master StartStopWithChild netcoreapp3.1 10.9μs 57.9ns 301ns 0.0328 0.0164 0 7.6 KB
master StartStopWithChild net472 16.7μs 76.8ns 307ns 1.36 0.35 0.117 8.05 KB
#5345 StartStopWithChild net6.0 8.99μs 48.3ns 269ns 0.0181 0.00905 0 7.51 KB
#5345 StartStopWithChild netcoreapp3.1 11.4μs 61.8ns 349ns 0.0235 0.0118 0 7.59 KB
#5345 StartStopWithChild net472 17.8μs 83.6ns 324ns 1.36 0.349 0.116 8.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 457μs 549ns 2.13μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 595μs 164ns 612ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 827μs 4.15μs 18.1μs 0.406 0 0 3.3 KB
#5345 WriteAndFlushEnrichedTraces net6.0 461μs 173ns 646ns 0 0 0 2.7 KB
#5345 WriteAndFlushEnrichedTraces netcoreapp3.1 617μs 529ns 2.05μs 0 0 0 2.7 KB
#5345 WriteAndFlushEnrichedTraces net472 815μs 251ns 907ns 0.406 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 110ns 412ns 0.17 0 0 18.33 KB
master SendRequest netcoreapp3.1 193μs 242ns 937ns 0.191 0 0 20.49 KB
master SendRequest net472 0.00106ns 0.000248ns 0.000893ns 0 0 0 0 b
#5345 SendRequest net6.0 174μs 238ns 921ns 0.174 0 0 18.33 KB
#5345 SendRequest netcoreapp3.1 193μs 312ns 1.17μs 0.192 0 0 20.49 KB
#5345 SendRequest net472 0.000597ns 0.000246ns 0.000922ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5345

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.71 KB 42.01 KB 298 B 0.71%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 564μs 2.63μs 10.2μs 0.563 0 0 41.59 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 540ns 1.95μs 0.326 0 0 41.71 KB
master WriteAndFlushEnrichedTraces net472 873μs 4.27μs 18.1μs 8.19 2.59 0.431 53.26 KB
#5345 WriteAndFlushEnrichedTraces net6.0 542μs 200ns 749ns 0.546 0 0 41.57 KB
#5345 WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 1.04μs 4.04μs 0.326 0 0 42.01 KB
#5345 WriteAndFlushEnrichedTraces net472 844μs 3.19μs 11.9μs 8.33 2.5 0.417 53.21 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.2μs 0.746ns 2.79ns 0.0108 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.59μs 0.482ns 1.87ns 0.0105 0 0 784 B
master ExecuteNonQuery net472 1.92μs 1.63ns 5.89ns 0.118 0 0 746 B
#5345 ExecuteNonQuery net6.0 1.17μs 0.56ns 2.1ns 0.0106 0 0 784 B
#5345 ExecuteNonQuery netcoreapp3.1 1.54μs 0.89ns 3.45ns 0.01 0 0 784 B
#5345 ExecuteNonQuery net472 1.79μs 1.24ns 4.81ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.34μs 0.371ns 1.39ns 0.0141 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.58μs 1.06ns 3.98ns 0.0134 0 0 1.01 KB
master CallElasticsearch net472 2.42μs 0.888ns 3.32ns 0.162 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.36μs 0.342ns 1.23ns 0.0136 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.7μs 1.4ns 5.42ns 0.0145 0 0 1.06 KB
master CallElasticsearchAsync net472 2.65μs 1.8ns 6.97ns 0.171 0 0 1.08 KB
#5345 CallElasticsearch net6.0 1.37μs 0.872ns 3.38ns 0.0143 0 0 1.01 KB
#5345 CallElasticsearch netcoreapp3.1 1.61μs 1.08ns 4.17ns 0.0135 0 0 1.01 KB
#5345 CallElasticsearch net472 2.57μs 2.8ns 10.8ns 0.161 0 0 1.02 KB
#5345 CallElasticsearchAsync net6.0 1.35μs 0.524ns 1.96ns 0.0135 0 0 984 B
#5345 CallElasticsearchAsync netcoreapp3.1 1.81μs 0.579ns 2.09ns 0.0146 0 0 1.06 KB
#5345 CallElasticsearchAsync net472 2.67μs 1.72ns 6.65ns 0.171 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5345

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.151 1,472.26 1,278.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.47μs 0.551ns 2.06ns 0.0132 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.981ns 3.8ns 0.0126 0 0 928 B
master ExecuteAsync net472 1.94μs 1.56ns 6.05ns 0.141 0 0 891 B
#5345 ExecuteAsync net6.0 1.28μs 0.42ns 1.57ns 0.013 0 0 928 B
#5345 ExecuteAsync netcoreapp3.1 1.69μs 3.08ns 11.9ns 0.0127 0 0 928 B
#5345 ExecuteAsync net472 1.91μs 0.423ns 1.53ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.3μs 3.67ns 13.7ns 0.0302 0 0 2.16 KB
master SendAsync netcoreapp3.1 4.99μs 1.73ns 6.23ns 0.0357 0 0 2.7 KB
master SendAsync net472 7.61μs 4.09ns 14.7ns 0.483 0 0 3.05 KB
#5345 SendAsync net6.0 4.08μs 3.71ns 12.8ns 0.0285 0 0 2.16 KB
#5345 SendAsync netcoreapp3.1 5.15μs 1.55ns 5.8ns 0.0358 0 0 2.7 KB
#5345 SendAsync net472 7.73μs 3.97ns 14.3ns 0.484 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.471ns 1.7ns 0.023 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.22μs 1.86ns 7.19ns 0.0225 0 0 1.65 KB
master EnrichedLog net472 2.59μs 1.28ns 4.8ns 0.25 0 0 1.57 KB
#5345 EnrichedLog net6.0 1.46μs 1.41ns 5.26ns 0.0235 0 0 1.65 KB
#5345 EnrichedLog netcoreapp3.1 2.3μs 0.851ns 3.19ns 0.022 0 0 1.65 KB
#5345 EnrichedLog net472 2.73μs 1.18ns 4.25ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 84.1ns 326ns 0.0556 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 117μs 166ns 642ns 0.0582 0 0 4.23 KB
master EnrichedLog net472 146μs 81.6ns 316ns 0.657 0.219 0 4.41 KB
#5345 EnrichedLog net6.0 114μs 185ns 717ns 0 0 0 4.23 KB
#5345 EnrichedLog netcoreapp3.1 120μs 153ns 593ns 0.0588 0 0 4.23 KB
#5345 EnrichedLog net472 147μs 50ns 180ns 0.66 0.22 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.09μs 1.06ns 3.83ns 0.0309 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.23μs 2.98ns 11.5ns 0.0301 0 0 2.21 KB
master EnrichedLog net472 5μs 2.24ns 8.38ns 0.319 0 0 2.02 KB
#5345 EnrichedLog net6.0 3.08μs 1.4ns 5.44ns 0.0307 0 0 2.21 KB
#5345 EnrichedLog netcoreapp3.1 4.38μs 2.16ns 8.37ns 0.0284 0 0 2.21 KB
#5345 EnrichedLog net472 4.85μs 5.09ns 19.7ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 0.836ns 3.24ns 0.0168 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.82μs 0.581ns 2.17ns 0.0155 0 0 1.18 KB
master SendReceive net472 2.27μs 1.87ns 7ns 0.187 0.00114 0 1.18 KB
#5345 SendReceive net6.0 1.38μs 0.916ns 3.17ns 0.0166 0 0 1.18 KB
#5345 SendReceive netcoreapp3.1 1.83μs 1.31ns 5.07ns 0.0157 0 0 1.18 KB
#5345 SendReceive net472 2.24μs 0.809ns 3.03ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 1.07ns 3.85ns 0.0221 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.97μs 2.08ns 8.07ns 0.0219 0 0 1.6 KB
master EnrichedLog net472 4.47μs 3.26ns 12.2ns 0.314 0 0 1.99 KB
#5345 EnrichedLog net6.0 2.74μs 1.2ns 4.47ns 0.0219 0 0 1.55 KB
#5345 EnrichedLog netcoreapp3.1 3.98μs 2.81ns 10.9ns 0.0218 0 0 1.6 KB
#5345 EnrichedLog net472 4.55μs 3.28ns 12.7ns 0.316 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5345

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.133 662.93 584.92

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 477ns 0.588ns 2.2ns 0.00765 0 0 552 B
master StartFinishSpan netcoreapp3.1 639ns 0.885ns 3.43ns 0.00757 0 0 552 B
master StartFinishSpan net472 781ns 1.37ns 5.31ns 0.088 0 0 554 B
master StartFinishScope net6.0 662ns 1.04ns 4.03ns 0.00954 0 0 672 B
master StartFinishScope netcoreapp3.1 922ns 1.18ns 4.42ns 0.00926 0 0 672 B
master StartFinishScope net472 940ns 0.797ns 3.09ns 0.101 0 0 634 B
#5345 StartFinishSpan net6.0 501ns 0.388ns 1.45ns 0.0078 0 0 552 B
#5345 StartFinishSpan netcoreapp3.1 689ns 0.807ns 3.02ns 0.00728 0 0 552 B
#5345 StartFinishSpan net472 756ns 0.368ns 1.33ns 0.0879 0 0 554 B
#5345 StartFinishScope net6.0 586ns 0.637ns 2.39ns 0.00944 0 0 672 B
#5345 StartFinishScope netcoreapp3.1 936ns 1.12ns 4.35ns 0.00887 0 0 672 B
#5345 StartFinishScope net472 986ns 0.381ns 1.48ns 0.1 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 678ns 1.16ns 4.5ns 0.00923 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 980ns 1.17ns 4.55ns 0.00932 0 0 672 B
master RunOnMethodBegin net472 1.07μs 1.15ns 4.44ns 0.1 0 0 634 B
#5345 RunOnMethodBegin net6.0 687ns 0.849ns 3.29ns 0.00936 0 0 672 B
#5345 RunOnMethodBegin netcoreapp3.1 978ns 1.07ns 4.14ns 0.00922 0 0 672 B
#5345 RunOnMethodBegin net472 1.08μs 0.562ns 2.18ns 0.1 0 0 634 B

@andrewlock
Copy link
Member

andrewlock commented Mar 23, 2024

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5345) (11.480M)   : 0, 11479996
    master (11.548M)   : 0, 11547759
    benchmarks/2.9.0 (11.390M)   : 0, 11390030

    section Automatic
    This PR (5345) (7.874M)   : 0, 7873601
    master (7.897M)   : 0, 7897327
    benchmarks/2.9.0 (8.387M)   : 0, 8386545

    section Trace stats
    This PR (5345) (8.260M)   : 0, 8259970
    master (8.226M)   : 0, 8226366

    section Manual
    This PR (5345) (10.082M)   : 0, 10081519
    master (9.990M)   : 0, 9989659

    section Manual + Automatic
    This PR (5345) (7.448M)   : 0, 7448094
    master (7.466M)   : 0, 7465946

    section Version Conflict
    This PR (5345) (6.714M)   : 0, 6714416
    master (6.762M)   : 0, 6762450

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5345) (9.229M)   : 0, 9228599
    master (9.533M)   : 0, 9533061
    benchmarks/2.9.0 (9.674M)   : 0, 9673866

    section Automatic
    This PR (5345) (6.633M)   : 0, 6633036
    master (6.545M)   : 0, 6545258

    section Trace stats
    This PR (5345) (6.944M)   : 0, 6943681
    master (6.848M)   : 0, 6847927

    section Manual
    This PR (5345) (8.306M)   : 0, 8305962
    master (8.065M)   : 0, 8064900

    section Manual + Automatic
    This PR (5345) (6.155M)   : 0, 6155451
    master (6.211M)   : 0, 6210873

    section Version Conflict
    This PR (5345) (5.747M)   : 0, 5747442
    master (5.631M)   : 0, 5630654

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5345) (9.403M)   : 0, 9402570

    section Automatic
    This PR (5345) (6.872M)   : 0, 6871510

    section Trace stats
    This PR (5345) (7.292M)   : 0, 7291543

    section Manual
    This PR (5345) (8.602M)   : 0, 8602278

    section Manual + Automatic
    This PR (5345) (6.687M)   : 0, 6686993

    section Version Conflict
    This PR (5345) (6.165M)   : 0, 6165368

Loading

@link04 link04 marked this pull request as ready for review March 23, 2024 23:39
@link04 link04 requested a review from a team as a code owner March 23, 2024 23:39
@link04 link04 changed the title Testing ASM Job Changes Disabling ASM Throughput Job Mar 27, 2024
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, let's just delete it for now. We can revert the commit in a PR later when we re-add it.

Also, don't forget to remove the ASM artifact download from the compare-throughput stage 🙂

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Thanks 👍

@link04 link04 merged commit b4c2b17 into master Mar 28, 2024
52 of 56 checks passed
@link04 link04 deleted the maximo/testing-with-ultimate-pipeline.yml branch March 28, 2024 14:30
@github-actions github-actions bot added this to the vNext milestone Mar 28, 2024
@andrewlock andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants