[Dynamic Instrumentation] Normalize redaction keywords + add missing keywords #5350

shurivich · 2024-03-26T12:04:44Z

Summary of changes

Normalize redaction keywords
Add missing keywords
Add unit tests

Reason for change

PII redaction was not working as expected because certain keywords weren't normalized. This update fix that issue. Additionally, after this functionality was initially introduced, some keywords were added; this update now includes them.
Also added some unit tests.

tracer/src/Datadog.Trace/Debugger/Snapshots/Redaction.cs

datadog-ddstaging · 2024-03-26T12:21:58Z

Datadog Report

Branch report: shurivich/pii
Commit report: 85f309c
Test service: dd-trace-dotnet

✅ 0 Failed, 333371 Passed, 2057 Skipped, 43m 7.89s Wall Time

andrewlock · 2024-03-26T12:28:07Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5350) - mean (74ms)  : 65, 83
     .   : milestone, 74,
    master - mean (73ms)  : 65, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5350) - mean (1,006ms)  : 982, 1030
     .   : milestone, 1006,
    master - mean (1,004ms)  : 981, 1026
     .   : milestone, 1004,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5350) - mean (113ms)  : 107, 119
     .   : milestone, 113,
    master - mean (111ms)  : 108, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5350) - mean (726ms)  : 705, 747
     .   : milestone, 726,
    master - mean (724ms)  : 700, 749
     .   : milestone, 724,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5350) - mean (95ms)  : 92, 97
     .   : milestone, 95,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5350) - mean (679ms)  : 653, 705
     .   : milestone, 679,
    master - mean (679ms)  : 656, 702
     .   : milestone, 679,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5350) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (188ms)  : 183, 193
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5350) - mean (1,078ms)  : 1056, 1100
     .   : milestone, 1078,
    master - mean (1,071ms)  : 1052, 1090
     .   : milestone, 1071,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5350) - mean (271ms)  : 268, 274
     .   : milestone, 271,
    master - mean (270ms)  : 263, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5350) - mean (868ms)  : 842, 893
     .   : milestone, 868,
    master - mean (866ms)  : 844, 888
     .   : milestone, 866,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5350) - mean (262ms)  : 257, 266
     .   : milestone, 262,
    master - mean (260ms)  : 254, 266
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5350) - mean (855ms)  : 829, 882
     .   : milestone, 855,
    master - mean (852ms)  : 826, 877
     .   : milestone, 852,

andrewlock · 2024-03-26T12:52:47Z

Benchmarks Report for tracer 🐌

Benchmarks for #5350 compared to master:

1 benchmarks are faster, with geometric mean 1.149
3 benchmarks are slower, with geometric mean 1.167
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.78μs	49ns	325ns	0.0176	0.0088	0	7.51 KB
master	`StartStopWithChild`	netcoreapp3.1	10.7μs	60.3ns	418ns	0.031	0.0155	0	7.6 KB
master	`StartStopWithChild`	net472	16.8μs	61.5ns	238ns	1.32	0.301	0.0835	8.04 KB
#5350	`StartStopWithChild`	net6.0	8.59μs	40.4ns	151ns	0.0411	0.0183	0	7.5 KB
#5350	`StartStopWithChild`	netcoreapp3.1	10.6μs	54.9ns	263ns	0.0307	0.0153	0.00511	7.59 KB
#5350	`StartStopWithChild`	net472	17μs	65.6ns	246ns	1.36	0.36	0.117	8.04 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	463μs	196ns	678ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	616μs	161ns	625ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	804μs	274ns	1.06μs	0.401	3.3 KB
#5350	`WriteAndFlushEnrichedTraces`	net6.0	464μs	258ns	1μs	0	2.7 KB
#5350	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	592μs	160ns	600ns	0	2.7 KB
#5350	`WriteAndFlushEnrichedTraces`	net472	818μs	315ns	1.18μs	0.408	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	154ns	597ns	0.184	18.33 KB
master	`SendRequest`	netcoreapp3.1	193μs	240ns	928ns	0.193	20.49 KB
master	`SendRequest`	net472	0.000852ns	0.000448ns	0.00161ns	0	0 b
#5350	`SendRequest`	net6.0	175μs	118ns	442ns	0.173	18.33 KB
#5350	`SendRequest`	netcoreapp3.1	194μs	213ns	825ns	0.194	20.49 KB
#5350	`SendRequest`	net472	0.00124ns	0.000537ns	0.00208ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5350

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.48 KB	41.72 KB	237 B	0.57%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	546μs	983ns	3.81μs	0.561	0	0	41.48 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	665μs	1.34μs	5.2μs	0.329	0	0	41.69 KB
master	`WriteAndFlushEnrichedTraces`	net472	870μs	3.69μs	14.3μs	8.13	2.57	0.428	53.25 KB
#5350	`WriteAndFlushEnrichedTraces`	net6.0	543μs	576ns	2.23μs	0.543	0	0	41.72 KB
#5350	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	669μs	1.01μs	3.78μs	0.331	0	0	41.68 KB
#5350	`WriteAndFlushEnrichedTraces`	net472	844μs	2.35μs	8.78μs	8.45	2.53	0.422	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.17μs	0.623ns	2.41ns	0.0111	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.58μs	5.33ns	20.6ns	0.0103	784 B
master	`ExecuteNonQuery`	net472	1.89μs	0.577ns	2.16ns	0.118	746 B
#5350	`ExecuteNonQuery`	net6.0	1.17μs	0.634ns	2.45ns	0.0113	784 B
#5350	`ExecuteNonQuery`	netcoreapp3.1	1.64μs	1.41ns	5.45ns	0.0106	784 B
#5350	`ExecuteNonQuery`	net472	1.77μs	0.831ns	3ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5350

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.245	1,202.72	1,497.80

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.2μs	0.599ns	2.24ns	0.0138	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.769ns	2.98ns	0.0138	1.01 KB
master	`CallElasticsearch`	net472	2.58μs	2.45ns	9.47ns	0.162	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.47μs	1.39ns	5.19ns	0.0138	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.74μs	0.684ns	2.56ns	0.0138	1.06 KB
master	`CallElasticsearchAsync`	net472	2.56μs	1.96ns	7.59ns	0.17	1.08 KB
#5350	`CallElasticsearch`	net6.0	1.5μs	1.75ns	6.77ns	0.0144	1.01 KB
#5350	`CallElasticsearch`	netcoreapp3.1	1.68μs	0.743ns	2.88ns	0.0134	1.01 KB
#5350	`CallElasticsearch`	net472	2.57μs	1.38ns	5.34ns	0.161	1.02 KB
#5350	`CallElasticsearchAsync`	net6.0	1.46μs	1.35ns	5.06ns	0.0138	984 B
#5350	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	0.806ns	3.02ns	0.014	1.06 KB
#5350	`CallElasticsearchAsync`	net472	2.76μs	2.23ns	8.63ns	0.17	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.26μs	1.21ns	4.51ns	0.0127	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.751ns	2.91ns	0.013	928 B
master	`ExecuteAsync`	net472	1.9μs	0.575ns	2.15ns	0.141	891 B
#5350	`ExecuteAsync`	net6.0	1.34μs	0.438ns	1.7ns	0.0128	928 B
#5350	`ExecuteAsync`	netcoreapp3.1	1.61μs	0.968ns	3.62ns	0.0129	928 B
#5350	`ExecuteAsync`	net472	1.97μs	0.673ns	2.61ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.24μs	1.91ns	7.14ns	0.0298	2.16 KB
master	`SendAsync`	netcoreapp3.1	5.06μs	2.59ns	10ns	0.0352	2.7 KB
master	`SendAsync`	net472	7.61μs	4.46ns	16.1ns	0.484	3.05 KB
#5350	`SendAsync`	net6.0	4.11μs	1.48ns	5.54ns	0.0288	2.16 KB
#5350	`SendAsync`	netcoreapp3.1	5.06μs	3.82ns	14.8ns	0.0353	2.7 KB
#5350	`SendAsync`	net472	7.79μs	4.07ns	15.8ns	0.483	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5350

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1	1.134	2,187.72	2,481.18

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.46μs	0.675ns	2.62ns	0.0228	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.19μs	0.863ns	3.23ns	0.0227	1.65 KB
master	`EnrichedLog`	net472	2.68μs	2.41ns	9.35ns	0.249	1.57 KB
#5350	`EnrichedLog`	net6.0	1.44μs	0.656ns	2.54ns	0.0232	1.65 KB
#5350	`EnrichedLog`	netcoreapp3.1	2.48μs	1.67ns	6.49ns	0.0224	1.65 KB
#5350	`EnrichedLog`	net472	2.82μs	3.01ns	11.6ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	77.8ns	301ns	0.0556	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	287ns	1.11μs	0.0591	0	4.23 KB
master	`EnrichedLog`	net472	148μs	151ns	566ns	0.665	0.222	4.41 KB
#5350	`EnrichedLog`	net6.0	112μs	96.5ns	374ns	0	0	4.23 KB
#5350	`EnrichedLog`	netcoreapp3.1	119μs	228ns	884ns	0	0	4.23 KB
#5350	`EnrichedLog`	net472	147μs	132ns	513ns	0.662	0.221	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.21ns	4.35ns	0.0316	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.15μs	2.14ns	8.27ns	0.0288	2.21 KB
master	`EnrichedLog`	net472	4.82μs	3.46ns	13.4ns	0.321	2.02 KB
#5350	`EnrichedLog`	net6.0	2.96μs	1.3ns	4.85ns	0.0312	2.21 KB
#5350	`EnrichedLog`	netcoreapp3.1	4.33μs	2.19ns	8.5ns	0.0302	2.21 KB
#5350	`EnrichedLog`	net472	5.29μs	1.14ns	4.1ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.45μs	0.621ns	2.24ns	0.0167	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.79μs	0.434ns	1.56ns	0.016	1.18 KB
master	`SendReceive`	net472	2.18μs	1.17ns	4.55ns	0.187	1.18 KB
#5350	`SendReceive`	net6.0	1.38μs	0.637ns	2.47ns	0.0166	1.18 KB
#5350	`SendReceive`	netcoreapp3.1	1.79μs	0.86ns	3.22ns	0.0161	1.18 KB
#5350	`SendReceive`	net472	2.25μs	2ns	7.2ns	0.186	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	0.804ns	2.78ns	0.0221	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	3.86μs	2.09ns	8.1ns	0.0214	1.6 KB
master	`EnrichedLog`	net472	4.51μs	3.37ns	13.1ns	0.315	1.99 KB
#5350	`EnrichedLog`	net6.0	2.85μs	0.642ns	2.31ns	0.0214	1.55 KB
#5350	`EnrichedLog`	netcoreapp3.1	3.93μs	1.73ns	6.69ns	0.0217	1.6 KB
#5350	`EnrichedLog`	net472	4.4μs	2.82ns	10.9ns	0.316	1.99 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5350

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.125	684.89	770.39

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	464ns	0.309ns	1.16ns	0.00761	552 B
master	`StartFinishSpan`	netcoreapp3.1	685ns	0.576ns	2.16ns	0.0072	552 B
master	`StartFinishSpan`	net472	803ns	1.01ns	3.64ns	0.0879	554 B
master	`StartFinishScope`	net6.0	685ns	0.886ns	3.43ns	0.00959	672 B
master	`StartFinishScope`	netcoreapp3.1	872ns	0.722ns	2.8ns	0.00878	672 B
master	`StartFinishScope`	net472	977ns	1.28ns	4.95ns	0.1	634 B
#5350	`StartFinishSpan`	net6.0	495ns	0.647ns	2.42ns	0.00778	552 B
#5350	`StartFinishSpan`	netcoreapp3.1	768ns	2.83ns	10.9ns	0.0073	552 B
#5350	`StartFinishSpan`	net472	812ns	1.06ns	4.11ns	0.0879	554 B
#5350	`StartFinishScope`	net6.0	620ns	0.585ns	2.19ns	0.0093	672 B
#5350	`StartFinishScope`	netcoreapp3.1	912ns	2.43ns	9.43ns	0.00897	672 B
#5350	`StartFinishScope`	net472	946ns	1.28ns	4.98ns	0.101	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5350

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.149	749.78	652.59

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	750ns	0.672ns	2.6ns	0.00945	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	943ns	0.716ns	2.58ns	0.00918	672 B
master	`RunOnMethodBegin`	net472	1.1μs	1.29ns	4.99ns	0.101	634 B
#5350	`RunOnMethodBegin`	net6.0	651ns	0.943ns	3.65ns	0.00948	672 B
#5350	`RunOnMethodBegin`	netcoreapp3.1	921ns	0.928ns	3.59ns	0.00918	672 B
#5350	`RunOnMethodBegin`	net472	1.08μs	1.58ns	6.13ns	0.101	634 B

andrewlock · 2024-03-26T14:20:44Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5350) (11.599M)   : 0, 11598773
    master (11.234M)   : 0, 11234211
    benchmarks/2.9.0 (11.502M)   : 0, 11502400

    section Automatic
    This PR (5350) (7.992M)   : 0, 7992150
    master (7.892M)   : 0, 7892025
    benchmarks/2.9.0 (8.282M)   : 0, 8282092

    section Trace stats
    This PR (5350) (8.215M)   : 0, 8215130
    master (8.128M)   : 0, 8128046

    section Manual
    This PR (5350) (10.004M)   : 0, 10003783
    master (9.998M)   : 0, 9997703

    section Manual + Automatic
    This PR (5350) (7.562M)   : 0, 7561919
    master (7.509M)   : 0, 7508673

    section Version Conflict
    This PR (5350) (6.745M)   : 0, 6745413
    master (6.752M)   : 0, 6751551

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5350) (9.658M)   : 0, 9657745
    master (9.719M)   : 0, 9719411
    benchmarks/2.9.0 (9.757M)   : 0, 9756597

    section Automatic
    This PR (5350) (4.734M)   : crit ,0, 4734157
    master (6.497M)   : 0, 6496614

    section Trace stats
    This PR (5350) (6.907M)   : 0, 6907427
    master (6.785M)   : 0, 6785156

    section Manual
    This PR (5350) (8.139M)   : 0, 8139463
    master (8.060M)   : 0, 8060205

    section Manual + Automatic
    This PR (5350) (6.143M)   : 0, 6142795
    master (5.959M)   : 0, 5958606

    section Version Conflict
    This PR (5350) (5.626M)   : 0, 5625942
    master (5.660M)   : 0, 5660029

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5350) (9.674M)   : 0, 9673633
    master (10.074M)   : 0, 10073856
    benchmarks/2.9.0 (9.814M)   : 0, 9813729

    section Automatic
    This PR (5350) (6.853M)   : 0, 6853231
    master (7.026M)   : 0, 7026117
    benchmarks/2.9.0 (7.278M)   : 0, 7278101

    section Trace stats
    This PR (5350) (7.159M)   : 0, 7158903
    master (7.281M)   : 0, 7281475

    section Manual
    This PR (5350) (8.372M)   : 0, 8371851
    master (8.613M)   : 0, 8613073

    section Manual + Automatic
    This PR (5350) (6.563M)   : 0, 6562960
    master (6.856M)   : 0, 6855748

    section Version Conflict
    This PR (5350) (5.951M)   : 0, 5950622
    master (6.081M)   : 0, 6080626

OmerRaviv

LGTM, great job on the test!

GreenMatan

LGTM

normalize _redactKeywords + add tests

85f309c

shurivich added the area:debugger label Mar 26, 2024

shurivich self-assigned this Mar 26, 2024

shurivich requested a review from a team as a code owner March 26, 2024 12:04

shurivich changed the title ~~[Dynamic Instrumentation] Normalize redaction keywords~~ [Dynamic Instrumentation] Normalize redaction keywords + add missing keywords Mar 26, 2024

andrewlock reviewed Mar 26, 2024

View reviewed changes

tracer/src/Datadog.Trace/Debugger/Snapshots/Redaction.cs Show resolved Hide resolved

shurivich requested review from GreenMatan and OmerRaviv March 26, 2024 13:55

OmerRaviv approved these changes Mar 27, 2024

View reviewed changes

GreenMatan approved these changes Mar 27, 2024

View reviewed changes

shurivich merged commit bea28a4 into master Mar 27, 2024
61 checks passed

shurivich deleted the shurivich/pii branch March 27, 2024 14:06

github-actions bot added this to the vNext milestone Mar 27, 2024

andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Normalize redaction keywords + add missing keywords #5350

[Dynamic Instrumentation] Normalize redaction keywords + add missing keywords #5350

shurivich commented Mar 26, 2024

datadog-ddstaging bot commented Mar 26, 2024 •

edited

Loading

andrewlock commented Mar 26, 2024

andrewlock commented Mar 26, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #5350

Raw results

Raw results

Slower ⚠️ in #5350

Raw results

Raw results

Raw results

Slower ⚠️ in #5350

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5350

Raw results

Faster 🎉 in #5350

Raw results

andrewlock commented Mar 26, 2024

OmerRaviv left a comment

GreenMatan left a comment

[Dynamic Instrumentation] Normalize redaction keywords + add missing keywords #5350

[Dynamic Instrumentation] Normalize redaction keywords + add missing keywords #5350

Conversation

shurivich commented Mar 26, 2024

Summary of changes

Reason for change

datadog-ddstaging bot commented Mar 26, 2024 • edited Loading

Datadog Report

andrewlock commented Mar 26, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Mar 26, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5350

Raw results

Raw results

Slower ⚠️ in #5350

Raw results

Raw results

Raw results

Slower ⚠️ in #5350

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5350

Raw results

Faster 🎉 in #5350

Raw results

andrewlock commented Mar 26, 2024

Throughput/Crank Report:zap:

OmerRaviv left a comment

Choose a reason for hiding this comment

GreenMatan left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Mar 26, 2024 •

edited

Loading