Split the macos build into 2 jobs and parallelise #5390

andrewlock · 2024-04-03T16:43:45Z

Summary of changes

Splits the build_macos stage into 2 jobs and runs them in parallel

Reason for change

The build_macos job is slow, over-an-hour slow. And it's a prerequisite for the dd-trace tool build, which is in turn a prerequisite for the tool artifact tests and the tool installer tests.

Implementation details

Similar to how we had to do with the linux tracer (though we didn't parallelise there currently, we could consider it). Splits the build into two separate jobs:

Build the managed loader and the native tracer. The native tracer takes ~25-30 mins to build.
Build the managed code (up to 15 mins) and the native loader (~10 mins).

We then add a third job that recombines the artifacts to give the same "existing" artifacts as we currently produce, namely the tracer home ~~and the "current build directory"~~ I didn't bother downloading the whole mac directory and re-uploading it in the end. As the macos unit tests are the only place we need this currently, just re-downloading them there instead

Test coverage

If it works, we're good

Other details

Even with this, the stage is still the slowest build stage by a factor of 2, but I'm not sure there's much more we can do to improve that.

…so needs to be explicitly downloaded

datadog-ddstaging · 2024-04-03T17:06:35Z

Datadog Report

Branch report: andrew/ci/split-macos-build
Commit report: 9ed8745
Test service: dd-trace-dotnet

✅ 0 Failed, 327918 Passed, 1583 Skipped, 42m 14.52s Wall Time

andrewlock · 2024-04-03T17:23:10Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5390) - mean (74ms)  : 65, 82
     .   : milestone, 74,
    master - mean (75ms)  : 65, 84
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5390) - mean (998ms)  : 977, 1019
     .   : milestone, 998,
    master - mean (1,004ms)  : 979, 1029
     .   : milestone, 1004,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5390) - mean (109ms)  : 106, 113
     .   : milestone, 109,
    master - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5390) - mean (717ms)  : 691, 742
     .   : milestone, 717,
    master - mean (723ms)  : 698, 747
     .   : milestone, 723,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5390) - mean (94ms)  : 91, 96
     .   : milestone, 94,
    master - mean (95ms)  : 91, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5390) - mean (670ms)  : 637, 703
     .   : milestone, 670,
    master - mean (676ms)  : 657, 695
     .   : milestone, 676,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5390) - mean (189ms)  : 185, 192
     .   : milestone, 189,
    master - mean (188ms)  : 185, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5390) - mean (1,081ms)  : 1051, 1110
     .   : milestone, 1081,
    master - mean (1,081ms)  : 1059, 1104
     .   : milestone, 1081,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5390) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5390) - mean (878ms)  : 853, 904
     .   : milestone, 878,
    master - mean (875ms)  : 852, 899
     .   : milestone, 875,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5390) - mean (261ms)  : 256, 266
     .   : milestone, 261,
    master - mean (262ms)  : 257, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (5390) - mean (853ms)  : 830, 875
     .   : milestone, 853,
    master - mean (862ms)  : 840, 885
     .   : milestone, 862,

andrewlock · 2024-04-03T18:20:34Z

Benchmarks Report for tracer 🐌

Benchmarks for #5390 compared to master:

1 benchmarks are faster, with geometric mean 1.234
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.9μs	49.2ns	291ns	0.022	0.0088	0	7.5 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	55ns	252ns	0.0373	0.0213	0.00533	7.59 KB
master	`StartStopWithChild`	net472	16.9μs	52.5ns	196ns	1.35	0.357	0.116	8.04 KB
#5390	`StartStopWithChild`	net6.0	8.71μs	45.1ns	226ns	0.025	0.0125	0	7.51 KB
#5390	`StartStopWithChild`	netcoreapp3.1	10.6μs	58.5ns	346ns	0.0256	0.0103	0	7.6 KB
#5390	`StartStopWithChild`	net472	17.1μs	61.2ns	237ns	1.33	0.334	0.1	8.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	483μs	547ns	2.12μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	606μs	323ns	1.25μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	820μs	234ns	877ns	0.411	3.3 KB
#5390	`WriteAndFlushEnrichedTraces`	net6.0	460μs	353ns	1.27μs	0	2.7 KB
#5390	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	615μs	227ns	819ns	0	2.7 KB
#5390	`WriteAndFlushEnrichedTraces`	net472	815μs	187ns	675ns	0.403	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	173μs	170ns	658ns	0.26	18.33 KB
master	`SendRequest`	netcoreapp3.1	194μs	249ns	964ns	0.193	20.49 KB
master	`SendRequest`	net472	0.000266ns	0.000143ns	0.000535ns	0	0 b
#5390	`SendRequest`	net6.0	174μs	174ns	674ns	0.174	18.33 KB
#5390	`SendRequest`	netcoreapp3.1	192μs	379ns	1.47μs	0.193	20.49 KB
#5390	`SendRequest`	net472	0.00189ns	0.000383ns	0.00143ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5390

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.61 KB	42.03 KB	412 B	0.99%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	550μs	640ns	2.22μs	0.563	0	0	41.54 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	2.34μs	9.05μs	0.327	0	0	41.61 KB
master	`WriteAndFlushEnrichedTraces`	net472	878μs	3.69μs	13.3μs	8.25	2.6	0.434	53.26 KB
#5390	`WriteAndFlushEnrichedTraces`	net6.0	543μs	1.32μs	4.94μs	0.539	0	0	41.75 KB
#5390	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	1.54μs	5.98μs	0.326	0	0	42.03 KB
#5390	`WriteAndFlushEnrichedTraces`	net472	858μs	4.44μs	21.3μs	8.39	2.52	0.419	53.26 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.11μs	0.528ns	1.91ns	0.0111	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.52μs	0.429ns	1.49ns	0.0105	784 B
master	`ExecuteNonQuery`	net472	1.81μs	0.473ns	1.77ns	0.118	746 B
#5390	`ExecuteNonQuery`	net6.0	1.19μs	0.901ns	3.49ns	0.0107	784 B
#5390	`ExecuteNonQuery`	netcoreapp3.1	1.51μs	2.41ns	9.32ns	0.0107	784 B
#5390	`ExecuteNonQuery`	net472	1.81μs	0.635ns	2.38ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.37μs	1.79ns	6.69ns	0.0137	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.63μs	2.75ns	10.3ns	0.014	1.01 KB
master	`CallElasticsearch`	net472	2.39μs	0.879ns	3.29ns	0.162	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.37μs	0.953ns	3.57ns	0.0137	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.965ns	3.74ns	0.014	1.06 KB
master	`CallElasticsearchAsync`	net472	2.69μs	2.35ns	9.08ns	0.17	1.08 KB
#5390	`CallElasticsearch`	net6.0	1.31μs	0.879ns	3.41ns	0.0144	1.01 KB
#5390	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.929ns	3.47ns	0.0138	1.01 KB
#5390	`CallElasticsearch`	net472	2.56μs	1.88ns	7.28ns	0.161	1.02 KB
#5390	`CallElasticsearchAsync`	net6.0	1.28μs	1.83ns	6.84ns	0.014	984 B
#5390	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.61ns	6.42ns	0.0145	1.06 KB
#5390	`CallElasticsearchAsync`	net472	2.65μs	0.837ns	3.13ns	0.17	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.36μs	0.623ns	2.41ns	0.0129	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.877ns	3.28ns	0.0127	928 B
master	`ExecuteAsync`	net472	2.03μs	0.82ns	3.18ns	0.141	891 B
#5390	`ExecuteAsync`	net6.0	1.38μs	0.526ns	2.04ns	0.013	928 B
#5390	`ExecuteAsync`	netcoreapp3.1	1.68μs	1.05ns	4.06ns	0.0125	928 B
#5390	`ExecuteAsync`	net472	1.92μs	0.651ns	2.26ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.14μs	1.06ns	3.98ns	0.029	2.16 KB
master	`SendAsync`	netcoreapp3.1	5.21μs	1.79ns	6.44ns	0.0364	2.7 KB
master	`SendAsync`	net472	7.88μs	2.92ns	10.9ns	0.484	3.05 KB
#5390	`SendAsync`	net6.0	4.34μs	1.59ns	5.74ns	0.0302	2.16 KB
#5390	`SendAsync`	netcoreapp3.1	5.16μs	1.14ns	4.28ns	0.0362	2.7 KB
#5390	`SendAsync`	net472	7.82μs	4.01ns	15.5ns	0.482	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.794ns	3.07ns	0.0231	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	0.823ns	3.08ns	0.0226	1.65 KB
master	`EnrichedLog`	net472	2.71μs	1.9ns	7.38ns	0.25	1.57 KB
#5390	`EnrichedLog`	net6.0	1.47μs	0.767ns	2.97ns	0.0228	1.65 KB
#5390	`EnrichedLog`	netcoreapp3.1	2.36μs	1.64ns	6.15ns	0.0214	1.65 KB
#5390	`EnrichedLog`	net472	2.72μs	2.69ns	10.4ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	35.1ns	136ns	0	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	135ns	503ns	0	0	4.23 KB
master	`EnrichedLog`	net472	147μs	113ns	436ns	0.659	0.22	4.41 KB
#5390	`EnrichedLog`	net6.0	111μs	133ns	516ns	0.0553	0	4.23 KB
#5390	`EnrichedLog`	netcoreapp3.1	118μs	136ns	526ns	0	0	4.23 KB
#5390	`EnrichedLog`	net472	147μs	106ns	411ns	0.659	0.22	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	1.44ns	5.56ns	0.0307	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.23μs	1.73ns	6.72ns	0.0296	2.21 KB
master	`EnrichedLog`	net472	5.02μs	2.02ns	7.84ns	0.321	2.02 KB
#5390	`EnrichedLog`	net6.0	2.87μs	1.52ns	5.88ns	0.0301	2.21 KB
#5390	`EnrichedLog`	netcoreapp3.1	4.23μs	2.2ns	8.23ns	0.0295	2.21 KB
#5390	`EnrichedLog`	net472	4.98μs	2.08ns	8.05ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.5μs	0.596ns	2.23ns	0.0164	0	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.79μs	1.67ns	6.26ns	0.0161	0	1.18 KB
master	`SendReceive`	net472	2.28μs	1.64ns	6.14ns	0.187	0	1.18 KB
#5390	`SendReceive`	net6.0	1.36μs	0.677ns	2.53ns	0.0164	0	1.18 KB
#5390	`SendReceive`	netcoreapp3.1	1.89μs	1.57ns	5.88ns	0.0151	0	1.18 KB
#5390	`SendReceive`	net472	2.28μs	1.15ns	4.47ns	0.187	0.00113	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.67μs	0.828ns	3.1ns	0.0213	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	3.95μs	1.41ns	5.07ns	0.02	1.6 KB
master	`EnrichedLog`	net472	4.35μs	2.05ns	7.67ns	0.316	1.99 KB
#5390	`EnrichedLog`	net6.0	2.86μs	0.975ns	3.51ns	0.0215	1.55 KB
#5390	`EnrichedLog`	netcoreapp3.1	4.08μs	1.37ns	5.3ns	0.0204	1.6 KB
#5390	`EnrichedLog`	net472	4.48μs	2.97ns	11.5ns	0.315	1.99 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5390

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.234	561.97	455.57

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	562ns	1.54ns	5.96ns	0.00762	552 B
master	`StartFinishSpan`	netcoreapp3.1	777ns	2.36ns	9.13ns	0.00762	552 B
master	`StartFinishSpan`	net472	760ns	1.73ns	6.7ns	0.0878	554 B
master	`StartFinishScope`	net6.0	626ns	1.34ns	5.2ns	0.00931	672 B
master	`StartFinishScope`	netcoreapp3.1	903ns	1.49ns	5.78ns	0.009	672 B
master	`StartFinishScope`	net472	929ns	1.58ns	6.13ns	0.1	634 B
#5390	`StartFinishSpan`	net6.0	456ns	0.608ns	2.36ns	0.0078	552 B
#5390	`StartFinishSpan`	netcoreapp3.1	699ns	0.969ns	3.75ns	0.00745	552 B
#5390	`StartFinishSpan`	net472	758ns	1.07ns	4.16ns	0.088	554 B
#5390	`StartFinishScope`	net6.0	589ns	0.962ns	3.73ns	0.00948	672 B
#5390	`StartFinishScope`	netcoreapp3.1	850ns	1.63ns	6.33ns	0.00933	672 B
#5390	`StartFinishScope`	net472	939ns	2.45ns	9.49ns	0.1	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	722ns	1.64ns	6.33ns	0.0094	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	865ns	2.46ns	9.52ns	0.009	672 B
master	`RunOnMethodBegin`	net472	1.08μs	1.61ns	6.01ns	0.1	634 B
#5390	`RunOnMethodBegin`	net6.0	749ns	2.21ns	8.56ns	0.00957	672 B
#5390	`RunOnMethodBegin`	netcoreapp3.1	898ns	1.65ns	6.38ns	0.00885	672 B
#5390	`RunOnMethodBegin`	net472	1.07μs	1.69ns	6.53ns	0.101	634 B

andrewlock · 2024-04-04T00:49:04Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5390) (11.078M)   : 0, 11078423
    master (10.962M)   : 0, 10961969
    benchmarks/2.9.0 (11.269M)   : 0, 11269029

    section Automatic
    This PR (5390) (7.639M)   : 0, 7638540
    master (7.503M)   : 0, 7503453
    benchmarks/2.9.0 (8.101M)   : 0, 8100962

    section Trace stats
    This PR (5390) (7.938M)   : 0, 7937958
    master (7.826M)   : 0, 7826349

    section Manual
    This PR (5390) (9.674M)   : 0, 9673898
    master (9.540M)   : 0, 9539506

    section Manual + Automatic
    This PR (5390) (7.319M)   : 0, 7318541
    master (7.140M)   : 0, 7140240

    section Version Conflict
    This PR (5390) (6.645M)   : 0, 6644545
    master (6.410M)   : 0, 6410320

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5390) (9.565M)   : 0, 9564632
    master (9.499M)   : 0, 9498868
    benchmarks/2.9.0 (9.648M)   : 0, 9648037

    section Automatic
    This PR (5390) (6.551M)   : 0, 6551060
    master (6.660M)   : 0, 6660300

    section Trace stats
    This PR (5390) (6.786M)   : 0, 6785928
    master (6.866M)   : 0, 6865962

    section Manual
    This PR (5390) (8.058M)   : 0, 8058028
    master (8.166M)   : 0, 8166096

    section Manual + Automatic
    This PR (5390) (6.201M)   : 0, 6201098
    master (6.173M)   : 0, 6173243

    section Version Conflict
    This PR (5390) (5.622M)   : 0, 5621889
    master (5.579M)   : 0, 5578907

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5390) (8.752M)   : 0, 8752425
    master (8.681M)   : 0, 8681195
    benchmarks/2.9.0 (8.991M)   : 0, 8990879

    section Automatic
    This PR (5390) (6.194M)   : 0, 6194458
    master (6.080M)   : 0, 6080451
    benchmarks/2.9.0 (6.362M)   : 0, 6361714

    section Trace stats
    This PR (5390) (6.291M)   : 0, 6291046
    master (6.327M)   : 0, 6326606

    section Manual
    This PR (5390) (7.682M)   : 0, 7681868
    master (7.608M)   : 0, 7607508

    section Manual + Automatic
    This PR (5390) (5.861M)   : 0, 5861278
    master (5.829M)   : 0, 5829141

    section Version Conflict
    This PR (5390) (5.338M)   : 0, 5337845
    master (5.284M)   : 0, 5283582

tonyredondo

Great!

andrewlock added 2 commits April 3, 2024 17:11

Try splitting macos build into multiple stages, because it's so slow

a83365a

The native tracer is built and uploaded separately for perf reasons, …

9ed8745

…so needs to be explicitly downloaded

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 3, 2024

andrewlock requested a review from a team as a code owner April 3, 2024 16:43

tonyredondo approved these changes Apr 4, 2024

View reviewed changes

andrewlock merged commit 3db9848 into master Apr 4, 2024
56 checks passed

andrewlock deleted the andrew/ci/split-macos-build branch April 4, 2024 09:15

github-actions bot added this to the vNext-v2 milestone Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split the macos build into 2 jobs and parallelise #5390

Split the macos build into 2 jobs and parallelise #5390

andrewlock commented Apr 3, 2024

datadog-ddstaging bot commented Apr 3, 2024 •

edited

Loading

andrewlock commented Apr 3, 2024

andrewlock commented Apr 3, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #5390

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5390

Raw results

Raw results

andrewlock commented Apr 4, 2024

tonyredondo left a comment

Split the macos build into 2 jobs and parallelise #5390

Split the macos build into 2 jobs and parallelise #5390

Conversation

andrewlock commented Apr 3, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Apr 3, 2024 • edited Loading

Datadog Report

andrewlock commented Apr 3, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 3, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5390

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5390

Raw results

Raw results

andrewlock commented Apr 4, 2024

Throughput/Crank Report:zap:

tonyredondo left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Apr 3, 2024 •

edited

Loading