Ignore complaints from NuGet about out of support packages #5415

andrewlock · 2024-04-08T11:22:55Z

Summary of changes

Ignore obsolete package warnings in sample dependency-libraries

Reason for change

Currently we get a bunch of warnings about using .NET Core and other packages e.g.

[WRN] CompileDependencyLib: C:\repos\dd-trace-dotnet\tracer\test\test-applications\integrations\dependency-libs\LogsInjectionHelper.VersionConflict\LogsInjectionHelper.VersionConflict.csproj : warning NU1903: Package 'Microsoft.NETCore.App' 2.1.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-2xjx-v99w-gqf3 [TargetFramework=netcoreapp2.1]
[WRN] CompileDependencyLib: C:\repos\dd-trace-dotnet\tracer\test\test-applications\integrations\dependency-libs\LogsInjectionHelper.VersionConflict\LogsInjectionHelper.VersionConflict.csproj : warning NU1902: Package 'Microsoft.NETCore.App' 2.1.0 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-3gp9-h8hw-pxpw [TargetFramework=netcoreapp2.1]
[WRN] CompileDependencyLib: C:\repos\dd-trace-dotnet\tracer\test\test-applications\integrations\dependency-libs\LogsInjectionHelper.VersionConflict\LogsInjectionHelper.VersionConflict.csproj : warning NU1903: Package 'Microsoft.NETCore.App' 2.1.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-3w5p-jhp5-c29q [TargetFramework=netcoreapp2.1]
[WRN] CompileDependencyLib: C:\repos\dd-trace-dotnet\tracer\test\test-applications\integrations\dependency-libs\LogsInjectionHelper.VersionConflict\LogsInjectionHelper.VersionConflict.csproj : warning NU1902: Package 'Microsoft.NETCore.App' 2.1.0 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-5633-f33j-c6f7 [TargetFramework=netcoreapp2.1]
12:18:14 [WRN] C:\repos\dd-trace-dotnet\tracer\test\test-applications\integrations\dependency-libs\Samples.SqlServer.Vb\Samples.SqlServer.Vb.vbproj : warning NU1902: Package 'System.Data.SqlClient' 4.1.0 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-8g2p-5pqh-5jmc [TargetFramework=netstandard2.0]
12:18:14 [WRN] C:\repos\dd-trace-dotnet\tracer\test\test-applications\integrations\dependency-libs\Samples.SqlServer.Vb\Samples.SqlServer.Vb.vbproj : warning NU1903: Package 'System.Data.SqlClient' 4.1.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-98g6-xh36-x2p7 [TargetFramework=netstandard2.0]

We want to use these versions for testing purposes, so they're just noise

Implementation details

Ignore the warnings

Test coverage

Tested locally, it works

Other details

datadog-ddstaging · 2024-04-08T11:38:30Z

Datadog Report

Branch report: andrew/ci/ignore-nuget-warnings
Commit report: 83630a8
Test service: dd-trace-dotnet

✅ 0 Failed, 331555 Passed, 1591 Skipped, 42m 9.96s Wall Time

andrewlock · 2024-04-08T11:46:49Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5415) - mean (72ms)  : 64, 81
     .   : milestone, 72,
    master - mean (74ms)  : 61, 87
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5415) - mean (997ms)  : 976, 1018
     .   : milestone, 997,
    master - mean (995ms)  : 979, 1010
     .   : milestone, 995,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5415) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5415) - mean (712ms)  : 686, 738
     .   : milestone, 712,
    master - mean (715ms)  : 689, 741
     .   : milestone, 715,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5415) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5415) - mean (673ms)  : 649, 696
     .   : milestone, 673,
    master - mean (665ms)  : 642, 689
     .   : milestone, 665,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5415) - mean (187ms)  : 182, 192
     .   : milestone, 187,
    master - mean (187ms)  : 185, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5415) - mean (1,070ms)  : 1044, 1096
     .   : milestone, 1070,
    master - mean (1,077ms)  : 1049, 1105
     .   : milestone, 1077,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5415) - mean (269ms)  : 263, 276
     .   : milestone, 269,
    master - mean (271ms)  : 268, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5415) - mean (865ms)  : 840, 890
     .   : milestone, 865,
    master - mean (877ms)  : 852, 902
     .   : milestone, 877,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5415) - mean (258ms)  : 250, 266
     .   : milestone, 258,
    master - mean (259ms)  : 254, 264
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (5415) - mean (853ms)  : 828, 877
     .   : milestone, 853,
    master - mean (851ms)  : 830, 872
     .   : milestone, 851,

andrewlock · 2024-04-08T12:12:34Z

Benchmarks Report for tracer 🐌

Benchmarks for #5415 compared to master:

3 benchmarks are slower, with geometric mean 1.132
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.58μs	42.5ns	199ns	0.0219	0.00874	0	7.51 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	54.8ns	257ns	0.0345	0.0173	0.00575	7.6 KB
master	`StartStopWithChild`	net472	17μs	51.1ns	191ns	1.35	0.334	0.106	8.05 KB
#5415	`StartStopWithChild`	net6.0	8.64μs	48ns	322ns	0.0216	0.00864	0	7.5 KB
#5415	`StartStopWithChild`	netcoreapp3.1	10.7μs	51.9ns	244ns	0.0264	0.0106	0	7.6 KB
#5415	`StartStopWithChild`	net472	16.9μs	48.9ns	189ns	1.36	0.367	0.117	8.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	488μs	220ns	853ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	605μs	154ns	595ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	818μs	494ns	1.91μs	0.403	3.3 KB
#5415	`WriteAndFlushEnrichedTraces`	net6.0	451μs	322ns	1.25μs	0	2.7 KB
#5415	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	610μs	385ns	1.49μs	0	2.7 KB
#5415	`WriteAndFlushEnrichedTraces`	net472	806μs	181ns	679ns	0.403	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	169ns	656ns	0.17	18.33 KB
master	`SendRequest`	netcoreapp3.1	191μs	244ns	946ns	0.19	20.49 KB
master	`SendRequest`	net472	0.000966ns	0.000316ns	0.00118ns	0	0 b
#5415	`SendRequest`	net6.0	171μs	346ns	1.25μs	0.256	18.33 KB
#5415	`SendRequest`	netcoreapp3.1	193μs	295ns	1.14μs	0.192	20.49 KB
#5415	`SendRequest`	net472	0.00125ns	0.000389ns	0.00151ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	544μs	341ns	1.28μs	0.563	0	0	41.52 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	1.58μs	6.11μs	0.324	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	842μs	3.54μs	13.7μs	8.39	2.52	0.419	53.24 KB
#5415	`WriteAndFlushEnrichedTraces`	net6.0	567μs	299ns	1.08μs	0.558	0	0	41.64 KB
#5415	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	402ns	1.51μs	0.329	0	0	41.79 KB
#5415	`WriteAndFlushEnrichedTraces`	net472	864μs	3.58μs	13.9μs	8.33	2.5	0.417	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5415

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.144	1,083.43	1,239.91

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.08μs	0.249ns	0.964ns	0.0109	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.51μs	2.37ns	9.17ns	0.0105	784 B
master	`ExecuteNonQuery`	net472	1.83μs	0.359ns	1.34ns	0.118	746 B
#5415	`ExecuteNonQuery`	net6.0	1.24μs	2.85ns	10.6ns	0.0106	784 B
#5415	`ExecuteNonQuery`	netcoreapp3.1	1.52μs	1.53ns	5.92ns	0.0108	784 B
#5415	`ExecuteNonQuery`	net472	1.81μs	1.26ns	4.54ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.342ns	1.28ns	0.0145	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.71μs	1.86ns	7.19ns	0.0135	1.01 KB
master	`CallElasticsearch`	net472	2.59μs	1.77ns	6.6ns	0.162	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.52ns	2.02ns	0.0135	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.76μs	0.811ns	2.92ns	0.0141	1.06 KB
master	`CallElasticsearchAsync`	net472	2.58μs	1.65ns	6.41ns	0.17	1.08 KB
#5415	`CallElasticsearch`	net6.0	1.31μs	0.761ns	2.95ns	0.0142	1.01 KB
#5415	`CallElasticsearch`	netcoreapp3.1	1.61μs	0.573ns	2.07ns	0.0139	1.01 KB
#5415	`CallElasticsearch`	net472	2.49μs	1.28ns	4.97ns	0.161	1.02 KB
#5415	`CallElasticsearchAsync`	net6.0	1.34μs	0.756ns	2.62ns	0.0134	984 B
#5415	`CallElasticsearchAsync`	netcoreapp3.1	1.74μs	2.67ns	10.3ns	0.014	1.06 KB
#5415	`CallElasticsearchAsync`	net472	2.58μs	2.82ns	10.5ns	0.17	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.97ns	3.76ns	0.0127	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.69μs	0.918ns	3.43ns	0.0129	928 B
master	`ExecuteAsync`	net472	1.92μs	4.05ns	14.6ns	0.141	891 B
#5415	`ExecuteAsync`	net6.0	1.29μs	0.488ns	1.83ns	0.013	928 B
#5415	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.526ns	1.97ns	0.0121	928 B
#5415	`ExecuteAsync`	net472	1.89μs	2.21ns	8.57ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.05μs	1.03ns	3.72ns	0.0303	2.16 KB
master	`SendAsync`	netcoreapp3.1	4.97μs	2.48ns	9.61ns	0.0346	2.7 KB
master	`SendAsync`	net472	7.72μs	8.52ns	31.9ns	0.484	3.05 KB
#5415	`SendAsync`	net6.0	4.2μs	1.88ns	7.27ns	0.0291	2.16 KB
#5415	`SendAsync`	netcoreapp3.1	5.03μs	2.35ns	8.46ns	0.0356	2.7 KB
#5415	`SendAsync`	net472	7.56μs	6.69ns	25.9ns	0.481	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.53μs	2.96ns	11.5ns	0.0233	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.16μs	0.907ns	3.39ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	2.83μs	1.16ns	4.35ns	0.249	1.57 KB
#5415	`EnrichedLog`	net6.0	1.51μs	0.609ns	2.36ns	0.0233	1.65 KB
#5415	`EnrichedLog`	netcoreapp3.1	2.36μs	1.13ns	4.24ns	0.0223	1.65 KB
#5415	`EnrichedLog`	net472	2.75μs	2.15ns	8.32ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	218ns	845ns	0.0565	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	139ns	519ns	0	0	4.23 KB
master	`EnrichedLog`	net472	147μs	131ns	507ns	0.659	0.22	4.41 KB
#5415	`EnrichedLog`	net6.0	114μs	149ns	559ns	0.0567	0	4.23 KB
#5415	`EnrichedLog`	netcoreapp3.1	118μs	239ns	926ns	0.059	0	4.23 KB
#5415	`EnrichedLog`	net472	147μs	115ns	444ns	0.661	0.22	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.87ns	7.25ns	0.0303	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	2.12ns	7.93ns	0.0297	2.21 KB
master	`EnrichedLog`	net472	4.81μs	5.36ns	20.8ns	0.321	2.02 KB
#5415	`EnrichedLog`	net6.0	3.08μs	9.23ns	35.7ns	0.0313	2.21 KB
#5415	`EnrichedLog`	netcoreapp3.1	4.17μs	3.18ns	11.9ns	0.0285	2.21 KB
#5415	`EnrichedLog`	net472	4.82μs	2.7ns	10.5ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.54μs	1.05ns	3.92ns	0.0162	0	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.91μs	0.803ns	2.9ns	0.0161	0	1.18 KB
master	`SendReceive`	net472	2.37μs	1.09ns	4.21ns	0.186	0	1.18 KB
#5415	`SendReceive`	net6.0	1.48μs	0.708ns	2.74ns	0.0163	0	1.18 KB
#5415	`SendReceive`	netcoreapp3.1	1.84μs	0.674ns	2.61ns	0.0156	0	1.18 KB
#5415	`SendReceive`	net472	2.21μs	1.14ns	4.11ns	0.187	0.0011	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	0.912ns	3.53ns	0.0222	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	2.19ns	8.19ns	0.0213	1.6 KB
master	`EnrichedLog`	net472	4.39μs	1.81ns	7.01ns	0.314	1.99 KB
#5415	`EnrichedLog`	net6.0	2.91μs	1.11ns	4.14ns	0.0217	1.55 KB
#5415	`EnrichedLog`	netcoreapp3.1	3.98μs	1.57ns	6.1ns	0.0218	1.6 KB
#5415	`EnrichedLog`	net472	4.57μs	1.99ns	7.45ns	0.315	1.99 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5415

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.126	679.55	765.27

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	526ns	1.29ns	5ns	0.00771	552 B
master	`StartFinishSpan`	netcoreapp3.1	728ns	1.4ns	5.43ns	0.0074	552 B
master	`StartFinishSpan`	net472	680ns	0.921ns	3.57ns	0.0877	554 B
master	`StartFinishScope`	net6.0	534ns	0.99ns	3.83ns	0.00946	672 B
master	`StartFinishScope`	netcoreapp3.1	925ns	1.46ns	5.64ns	0.00875	672 B
master	`StartFinishScope`	net472	977ns	1.67ns	6.25ns	0.101	634 B
#5415	`StartFinishSpan`	net6.0	537ns	1.55ns	5.81ns	0.00772	552 B
#5415	`StartFinishSpan`	netcoreapp3.1	728ns	1.25ns	4.85ns	0.00741	552 B
#5415	`StartFinishSpan`	net472	763ns	1.65ns	6.4ns	0.0877	554 B
#5415	`StartFinishScope`	net6.0	539ns	1.07ns	4.13ns	0.00928	672 B
#5415	`StartFinishScope`	netcoreapp3.1	840ns	1.14ns	4.4ns	0.00912	672 B
#5415	`StartFinishScope`	net472	952ns	1.36ns	4.9ns	0.1	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5415

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.124	640.77	720.36

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	640ns	1.19ns	4.6ns	0.00941	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	946ns	1.64ns	6.35ns	0.00861	672 B
master	`RunOnMethodBegin`	net472	1.17μs	3.27ns	12.7ns	0.101	634 B
#5415	`RunOnMethodBegin`	net6.0	719ns	1.29ns	5ns	0.0094	672 B
#5415	`RunOnMethodBegin`	netcoreapp3.1	950ns	1.81ns	7.01ns	0.00905	672 B
#5415	`RunOnMethodBegin`	net472	1.13μs	2.06ns	7.99ns	0.101	634 B

andrewlock · 2024-04-08T15:41:42Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5415) (11.141M)   : 0, 11141491
    master (11.291M)   : 0, 11290531
    benchmarks/2.9.0 (11.259M)   : 0, 11258931

    section Automatic
    This PR (5415) (7.683M)   : 0, 7683192
    master (7.812M)   : 0, 7811554
    benchmarks/2.9.0 (8.404M)   : 0, 8403894

    section Trace stats
    This PR (5415) (8.132M)   : 0, 8132445
    master (8.145M)   : 0, 8144806

    section Manual
    This PR (5415) (9.720M)   : 0, 9719954
    master (10.005M)   : 0, 10005270

    section Manual + Automatic
    This PR (5415) (7.351M)   : 0, 7350929
    master (7.452M)   : 0, 7451677

    section Version Conflict
    This PR (5415) (6.631M)   : 0, 6630736
    master (6.729M)   : 0, 6729042

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5415) (9.602M)   : 0, 9601508
    master (9.511M)   : 0, 9511159
    benchmarks/2.9.0 (9.538M)   : 0, 9538176

    section Automatic
    This PR (5415) (6.747M)   : 0, 6746566
    master (6.627M)   : 0, 6627415

    section Trace stats
    This PR (5415) (6.900M)   : 0, 6899614
    master (6.983M)   : 0, 6982663

    section Manual
    This PR (5415) (8.319M)   : 0, 8318878
    master (8.261M)   : 0, 8261054

    section Manual + Automatic
    This PR (5415) (6.158M)   : 0, 6158466
    master (6.265M)   : 0, 6264831

    section Version Conflict
    This PR (5415) (5.535M)   : 0, 5535035
    master (5.618M)   : 0, 5618458

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5415) (10.121M)   : 0, 10121130
    master (10.019M)   : 0, 10019270

    section Automatic
    This PR (5415) (7.280M)   : 0, 7279514
    master (7.151M)   : 0, 7151401

    section Trace stats
    This PR (5415) (7.516M)   : 0, 7516350
    master (7.467M)   : 0, 7467270

    section Manual
    This PR (5415) (9.125M)   : 0, 9124526
    master (8.890M)   : 0, 8889532

    section Manual + Automatic
    This PR (5415) (6.917M)   : 0, 6917055
    master (6.891M)   : 0, 6891455

    section Version Conflict
    This PR (5415) (6.236M)   : 0, 6236054
    master (6.189M)   : 0, 6188619

Ignore complaints from NuGet about out of support packages

83630a8

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 8, 2024

andrewlock requested a review from a team as a code owner April 8, 2024 11:22

github-actions bot added the area:tests unit tests, integration tests label Apr 8, 2024

bouwkast approved these changes Apr 8, 2024

View reviewed changes

lucaspimentel approved these changes Apr 8, 2024

View reviewed changes

andrewlock merged commit 17b24c3 into master Apr 9, 2024
56 of 57 checks passed

andrewlock deleted the andrew/ci/ignore-nuget-warnings branch April 9, 2024 08:46

github-actions bot added this to the vNext-v2 milestone Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore complaints from NuGet about out of support packages #5415

Ignore complaints from NuGet about out of support packages #5415

andrewlock commented Apr 8, 2024

datadog-ddstaging bot commented Apr 8, 2024 •

edited

Loading

andrewlock commented Apr 8, 2024

andrewlock commented Apr 8, 2024

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5415

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5415

Raw results

Slower ⚠️ in #5415

Raw results

andrewlock commented Apr 8, 2024

Ignore complaints from NuGet about out of support packages #5415

Ignore complaints from NuGet about out of support packages #5415

Conversation

andrewlock commented Apr 8, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Apr 8, 2024 • edited Loading

Datadog Report

andrewlock commented Apr 8, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 8, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5415

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5415

Raw results

Slower ⚠️ in #5415

Raw results

andrewlock commented Apr 8, 2024

Throughput/Crank Report:zap:

datadog-ddstaging bot commented Apr 8, 2024 •

edited

Loading