Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] Support legacy endpoint for diagnostics uploading #5456

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[Dynamic Instrumentation] Support legacy endpoint for diagnostics uploading #5456

merged 1 commit into from
Apr 17, 2024

Conversation

shurivich
Copy link
Contributor

@shurivich shurivich commented Apr 17, 2024 •
edited
Loading

Summary of changes

Use multipart request for diagnostics and JSON request for input endpoints

Reason for change

Support legacy endpoint for diagnostics uploading

@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Apr 17, 2024
@shurivich shurivich self-assigned this Apr 17, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Apr 17, 2024 •
edited
Loading

Datadog Report

Branch report: shurivich/legacy_endpoint
Commit report: 3db40ba
Test service: dd-trace-dotnet

✅ 0 Failed, 333186 Passed, 2004 Skipped, 41m 5.45s Wall Time
⌛ 2 Performance Regressions

⌛ Performance Regressions vs Default Branch (2)

  • Baseline - Samples.HttpMessageHandler.windows.net60.json.scenarios 268.27ms (+7.94ms, +3%) - Details
  • Baseline - Samples.HttpMessageHandler.windows.net462.json.scenarios 193.68ms (+5.78ms, +3%) - Details

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5456) - mean (74ms)  : 60, 89
     .   : milestone, 74,
    master - mean (74ms)  : 66, 81
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5456) - mean (1,017ms)  : 996, 1038
     .   : milestone, 1017,
    master - mean (1,016ms)  : 992, 1039
     .   : milestone, 1016,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5456) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5456) - mean (748ms)  : 721, 775
     .   : milestone, 748,
    master - mean (737ms)  : 716, 759
     .   : milestone, 737,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5456) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (94ms)  : 91, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5456) - mean (692ms)  : 673, 711
     .   : milestone, 692,
    master - mean (693ms)  : 675, 711
     .   : milestone, 693,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5456) - mean (194ms)  : 190, 197
     .   : milestone, 194,
    master - mean (192ms)  : 189, 194
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5456) - mean (1,102ms)  : 1080, 1123
     .   : milestone, 1102,
    master - mean (1,094ms)  : 1072, 1116
     .   : milestone, 1094,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5456) - mean (281ms)  : 277, 285
     .   : milestone, 281,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5456) - mean (894ms)  : 868, 920
     .   : milestone, 894,
    master - mean (884ms)  : 859, 909
     .   : milestone, 884,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5456) - mean (268ms)  : 265, 272
     .   : milestone, 268,
    master - mean (265ms)  : 259, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5456) - mean (873ms)  : 846, 900
     .   : milestone, 873,
    master - mean (865ms)  : 835, 894
     .   : milestone, 865,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5456 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.132
  • 2 benchmarks are slower, with geometric mean 1.153
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.95μs 44.1ns 225ns 0.0284 0.0142 0.00473 7.54 KB
master StartStopWithChild netcoreapp3.1 10.7μs 56.2ns 276ns 0.0253 0.0101 0 7.64 KB
master StartStopWithChild net472 17.1μs 49.2ns 191ns 1.34 0.335 0.103 8.07 KB
#5456 StartStopWithChild net6.0 8.99μs 42.6ns 176ns 0.0275 0.0138 0 7.53 KB
#5456 StartStopWithChild netcoreapp3.1 10.8μs 59ns 344ns 0.0285 0.0114 0 7.63 KB
#5456 StartStopWithChild net472 17.1μs 48ns 186ns 1.35 0.347 0.11 8.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 486μs 325ns 1.26μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 621μs 201ns 777ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 815μs 393ns 1.47μs 0.406 0 0 3.3 KB
#5456 WriteAndFlushEnrichedTraces net6.0 473μs 286ns 1.03μs 0 0 0 2.7 KB
#5456 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 354ns 1.32μs 0 0 0 2.7 KB
#5456 WriteAndFlushEnrichedTraces net472 822μs 625ns 2.42μs 0.408 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 169μs 157ns 609ns 0.252 0 0 18.38 KB
master SendRequest netcoreapp3.1 191μs 248ns 962ns 0.192 0 0 20.54 KB
master SendRequest net472 0.000134ns 0.000121ns 0.000452ns 0 0 0 0 b
#5456 SendRequest net6.0 168μs 251ns 971ns 0.251 0 0 18.38 KB
#5456 SendRequest netcoreapp3.1 189μs 224ns 838ns 0.191 0 0 20.54 KB
#5456 SendRequest net472 0.000956ns 0.00042ns 0.00157ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5456

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.68 KB 41.95 KB 272 B 0.65%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 533μs 262ns 1.02μs 0.556 0 0 41.53 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 766ns 2.97μs 0.326 0 0 41.68 KB
master WriteAndFlushEnrichedTraces net472 868μs 2.94μs 11.4μs 8.09 2.25 0.45 53.26 KB
#5456 WriteAndFlushEnrichedTraces net6.0 550μs 803ns 3.11μs 0.546 0 0 41.61 KB
#5456 WriteAndFlushEnrichedTraces netcoreapp3.1 660μs 1.61μs 6.22μs 0.332 0 0 41.95 KB
#5456 WriteAndFlushEnrichedTraces net472 866μs 3.37μs 13μs 8.33 2.5 0.417 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.17μs 0.429ns 1.66ns 0.0112 0 0 800 B
master ExecuteNonQuery netcoreapp3.1 1.51μs 0.877ns 3.4ns 0.0105 0 0 800 B
master ExecuteNonQuery net472 1.82μs 0.524ns 2.03ns 0.12 0 0 762 B
#5456 ExecuteNonQuery net6.0 1.25μs 1.02ns 3.96ns 0.0113 0 0 800 B
#5456 ExecuteNonQuery netcoreapp3.1 1.62μs 0.92ns 3.56ns 0.0107 0 0 800 B
#5456 ExecuteNonQuery net472 1.76μs 4.03ns 15.6ns 0.121 0 0 762 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 0.505ns 1.95ns 0.0144 0 0 1.02 KB
master CallElasticsearch netcoreapp3.1 1.59μs 0.873ns 3.27ns 0.0143 0 0 1.02 KB
master CallElasticsearch net472 2.46μs 1.49ns 5.79ns 0.164 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.29μs 0.989ns 3.7ns 0.0135 0 0 1 KB
master CallElasticsearchAsync netcoreapp3.1 1.77μs 0.811ns 3.03ns 0.0142 0 0 1.07 KB
master CallElasticsearchAsync net472 2.69μs 1.98ns 7.68ns 0.172 0 0 1.09 KB
#5456 CallElasticsearch net6.0 1.34μs 1.28ns 4.96ns 0.0141 0 0 1.02 KB
#5456 CallElasticsearch netcoreapp3.1 1.64μs 2.17ns 8.4ns 0.0139 0 0 1.02 KB
#5456 CallElasticsearch net472 2.5μs 1.34ns 5.03ns 0.164 0 0 1.04 KB
#5456 CallElasticsearchAsync net6.0 1.33μs 1.07ns 4.01ns 0.014 0 0 1 KB
#5456 CallElasticsearchAsync netcoreapp3.1 1.63μs 0.66ns 2.47ns 0.0145 0 0 1.07 KB
#5456 CallElasticsearchAsync net472 2.52μs 1.57ns 6.06ns 0.173 0.00126 0 1.09 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.45μs 0.509ns 1.97ns 0.013 0 0 944 B
master ExecuteAsync netcoreapp3.1 1.61μs 2.43ns 9.42ns 0.0122 0 0 944 B
master ExecuteAsync net472 1.85μs 2.88ns 11.2ns 0.143 0 0 907 B
#5456 ExecuteAsync net6.0 1.38μs 0.897ns 3.47ns 0.0132 0 0 944 B
#5456 ExecuteAsync netcoreapp3.1 1.76μs 0.693ns 2.59ns 0.0131 0 0 944 B
#5456 ExecuteAsync net472 1.74μs 0.486ns 1.82ns 0.143 0 0 907 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.15μs 1.71ns 6.4ns 0.031 0 0 2.18 KB
master SendAsync netcoreapp3.1 5.14μs 12.4ns 46.2ns 0.0358 0 0 2.71 KB
master SendAsync net472 7.71μs 2.44ns 9.46ns 0.484 0 0 3.07 KB
#5456 SendAsync net6.0 4.04μs 1.68ns 6.28ns 0.0303 0 0 2.18 KB
#5456 SendAsync netcoreapp3.1 5.25μs 3.98ns 15.4ns 0.0366 0 0 2.71 KB
#5456 SendAsync net472 7.8μs 2.08ns 7.49ns 0.486 0 0 3.07 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5456

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.132 2,400.58 2,120.79

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.59μs 0.766ns 2.97ns 0.0238 0 0 1.68 KB
master EnrichedLog netcoreapp3.1 2.4μs 0.911ns 3.28ns 0.0225 0 0 1.68 KB
master EnrichedLog net472 2.81μs 3.79ns 14.7ns 0.254 0 0 1.61 KB
#5456 EnrichedLog net6.0 1.48μs 0.459ns 1.72ns 0.0238 0 0 1.68 KB
#5456 EnrichedLog netcoreapp3.1 2.12μs 0.785ns 2.94ns 0.0234 0 0 1.68 KB
#5456 EnrichedLog net472 2.57μs 0.951ns 3.43ns 0.255 0 0 1.61 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 149ns 575ns 0.0562 0 0 4.26 KB
master EnrichedLog netcoreapp3.1 118μs 210ns 814ns 0.0592 0 0 4.26 KB
master EnrichedLog net472 149μs 145ns 563ns 0.668 0.223 0 4.45 KB
#5456 EnrichedLog net6.0 113μs 157ns 566ns 0.0578 0 0 4.26 KB
#5456 EnrichedLog netcoreapp3.1 118μs 120ns 464ns 0.0588 0 0 4.26 KB
#5456 EnrichedLog net472 149μs 92.5ns 334ns 0.67 0.223 0 4.45 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.93μs 0.998ns 3.74ns 0.0309 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 4.19μs 1.3ns 5.02ns 0.0294 0 0 2.24 KB
master EnrichedLog net472 4.9μs 1.9ns 7.35ns 0.325 0 0 2.05 KB
#5456 EnrichedLog net6.0 3.15μs 1.36ns 5.26ns 0.0315 0 0 2.24 KB
#5456 EnrichedLog netcoreapp3.1 4.16μs 4.14ns 15.5ns 0.029 0 0 2.24 KB
#5456 EnrichedLog net472 4.9μs 2.25ns 8.72ns 0.325 0 0 2.05 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 1.34ns 5.02ns 0.0168 0 0 1.19 KB
master SendReceive netcoreapp3.1 1.81μs 2.17ns 8.42ns 0.0163 0 0 1.19 KB
master SendReceive net472 2.2μs 1.72ns 6.2ns 0.19 0.00109 0 1.2 KB
#5456 SendReceive net6.0 1.4μs 0.407ns 1.57ns 0.0168 0 0 1.19 KB
#5456 SendReceive netcoreapp3.1 1.89μs 1.21ns 4.53ns 0.0161 0 0 1.19 KB
#5456 SendReceive net472 2.17μs 1.27ns 4.57ns 0.19 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.8μs 0.611ns 2.2ns 0.0224 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 3.83μs 2.55ns 9.87ns 0.0212 0 0 1.63 KB
master EnrichedLog net472 4.41μs 2.56ns 9.93ns 0.319 0 0 2.02 KB
#5456 EnrichedLog net6.0 2.64μs 0.91ns 3.52ns 0.0212 0 0 1.58 KB
#5456 EnrichedLog netcoreapp3.1 4.03μs 2.43ns 9.39ns 0.0221 0 0 1.63 KB
#5456 EnrichedLog net472 4.46μs 2.7ns 10.5ns 0.32 0 0 2.02 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5456

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.181 784.46 926.30
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.125 537.60 604.77

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 544ns 0.236ns 0.884ns 0.00792 0 0 568 B
master StartFinishSpan netcoreapp3.1 752ns 0.662ns 2.57ns 0.00759 0 0 568 B
master StartFinishSpan net472 830ns 0.624ns 2.42ns 0.0905 0 0 570 B
master StartFinishScope net6.0 538ns 0.347ns 1.3ns 0.00967 0 0 688 B
master StartFinishScope netcoreapp3.1 785ns 0.973ns 3.37ns 0.00947 0 0 688 B
master StartFinishScope net472 1.01μs 0.868ns 3.36ns 0.103 0 0 650 B
#5456 StartFinishSpan net6.0 515ns 0.304ns 1.05ns 0.00804 0 0 568 B
#5456 StartFinishSpan netcoreapp3.1 728ns 1.02ns 3.83ns 0.00758 0 0 568 B
#5456 StartFinishSpan net472 811ns 0.922ns 3.57ns 0.0904 0 0 570 B
#5456 StartFinishScope net6.0 604ns 0.495ns 1.79ns 0.00969 0 0 688 B
#5456 StartFinishScope netcoreapp3.1 925ns 1.56ns 6.05ns 0.00936 0 0 688 B
#5456 StartFinishScope net472 1.04μs 1.32ns 4.93ns 0.103 0 0 650 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 700ns 0.372ns 1.44ns 0.00975 0 0 688 B
master RunOnMethodBegin netcoreapp3.1 1.02μs 4.38ns 17ns 0.00916 0 0 688 B
master RunOnMethodBegin net472 1.11μs 0.989ns 3.83ns 0.103 0 0 650 B
#5456 RunOnMethodBegin net6.0 694ns 0.815ns 3.16ns 0.0097 0 0 688 B
#5456 RunOnMethodBegin netcoreapp3.1 967ns 1.57ns 6.07ns 0.00942 0 0 688 B
#5456 RunOnMethodBegin net472 1.19μs 1.28ns 4.97ns 0.103 0 0 650 B

@shurivich shurivich changed the title [Dynamic Instrumentation] Acknowledge legacy endpoint for diagnostics uploading [Dynamic Instrumentation] Support legacy endpoint for diagnostics uploading Apr 17, 2024
@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5456) (11.325M)   : 0, 11325249
    master (11.522M)   : 0, 11522381
    benchmarks/2.9.0 (11.170M)   : 0, 11169786

    section Automatic
    This PR (5456) (7.813M)   : 0, 7813010
    master (7.941M)   : 0, 7940524
    benchmarks/2.9.0 (8.435M)   : 0, 8434769

    section Trace stats
    master (8.315M)   : 0, 8314530

    section Manual
    This PR (5456) (9.884M)   : 0, 9883678
    master (9.988M)   : 0, 9988179

    section Manual + Automatic
    This PR (5456) (7.438M)   : 0, 7438153
    master (7.586M)   : 0, 7586252

    section Version Conflict
    master (6.763M)   : 0, 6762646
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5456) (9.676M)   : 0, 9675668
    master (9.577M)   : 0, 9576962
    benchmarks/2.9.0 (9.658M)   : 0, 9657706

    section Automatic
    This PR (5456) (6.698M)   : 0, 6698339
    master (6.559M)   : 0, 6558544

    section Trace stats
    master (6.899M)   : 0, 6899377

    section Manual
    This PR (5456) (8.299M)   : 0, 8299154
    master (8.285M)   : 0, 8284821

    section Manual + Automatic
    This PR (5456) (6.219M)   : 0, 6218880
    master (6.060M)   : 0, 6060400

    section Version Conflict
    master (5.577M)   : 0, 5576823
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5456) (9.905M)   : 0, 9905185
    master (9.719M)   : 0, 9718909
    benchmarks/2.9.0 (10.068M)   : 0, 10068415

    section Automatic
    This PR (5456) (7.036M)   : 0, 7036140
    master (7.165M)   : 0, 7165128
    benchmarks/2.9.0 (7.475M)   : 0, 7475050

    section Trace stats
    master (7.388M)   : 0, 7387740

    section Manual
    This PR (5456) (8.734M)   : 0, 8733893
    master (8.762M)   : 0, 8761881

    section Manual + Automatic
    This PR (5456) (6.651M)   : 0, 6651470
    master (6.864M)   : 0, 6863897

    section Version Conflict
    master (6.179M)   : 0, 6179007
Loading

@shurivich shurivich marked this pull request as ready for review April 17, 2024 10:10
@shurivich shurivich requested a review from a team as a code owner April 17, 2024 10:10
andrewlock
andrewlock approved these changes Apr 17, 2024
View reviewed changes
tracer/src/Datadog.Trace/Debugger/Upload/DiagnosticsUploadApi.cs

private Task<IApiResponse> PostAsync(string uri, ArraySegment<byte> data)
{
if (uri.Contains("diagnostics"))
Copy link
Member

@andrewlock andrewlock Apr 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit broad, are you sure you don't want to test for a specific path here 🤔 Given this is the "legacy" behaviour (I believe?) it might be a better option, as we don't expect it to change, and if the new url does change, we don't want to unexpectedly revert to the old behaviour?

(If so, obviously don't have to do in this PR, for speed purposes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinks it's a good idea, I will add a work item for this.

@andrewlock andrewlock merged commit aae2141 into master Apr 17, 2024
59 of 62 checks passed
@andrewlock andrewlock deleted the shurivich/legacy_endpoint branch April 17, 2024 11:05
@github-actions github-actions bot added this to the vNext-v2 milestone Apr 17, 2024
@shurivich shurivich mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudikeleti dudikeleti dudikeleti approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees

@shurivich shurivich

Labels
area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
2.50.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shurivich @andrewlock @dudikeleti