-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CallTargetNativeTests on Windows #5754
base: master
Are you sure you want to change the base?
Run CallTargetNativeTests on Windows #5754
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (71ms) : 68, 74
. : milestone, 71,
master - mean (70ms) : 67, 73
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (1,105ms) : 1082, 1127
. : milestone, 1105,
master - mean (1,100ms) : 1084, 1117
. : milestone, 1100,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (771ms) : 756, 786
. : milestone, 771,
master - mean (768ms) : 747, 789
. : milestone, 768,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (93ms) : 89, 96
. : milestone, 93,
master - mean (92ms) : 90, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (728ms) : 709, 747
. : milestone, 728,
master - mean (730ms) : 715, 746
. : milestone, 730,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (1,196ms) : 1170, 1221
. : milestone, 1196,
master - mean (1,198ms) : 1169, 1227
. : milestone, 1198,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (277ms) : 271, 282
. : milestone, 277,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (941ms) : 925, 957
. : milestone, 941,
master - mean (942ms) : 923, 961
. : milestone, 942,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5754) - mean (266ms) : 261, 270
. : milestone, 266,
master - mean (264ms) : 262, 267
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (5754) - mean (927ms) : 910, 945
. : milestone, 927,
master - mean (926ms) : 905, 947
. : milestone, 926,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5754) (11.161M) : 0, 11160749
master (10.927M) : 0, 10927139
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (5754) (7.191M) : 0, 7190892
master (7.322M) : 0, 7322055
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.600M) : 0, 7600325
section Manual
master (10.941M) : 0, 10940627
section Manual + Automatic
This PR (5754) (6.785M) : 0, 6785273
master (6.568M) : 0, 6568140
section DD_TRACE_ENABLED=0
master (10.242M) : 0, 10242149
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5754) (9.399M) : 0, 9398642
master (9.577M) : 0, 9577232
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (5754) (6.483M) : 0, 6483143
master (6.625M) : 0, 6625219
section Trace stats
master (6.872M) : 0, 6872290
section Manual
master (9.590M) : 0, 9589966
section Manual + Automatic
This PR (5754) (6.008M) : 0, 6008487
master (6.216M) : 0, 6216360
section DD_TRACE_ENABLED=0
master (8.849M) : 0, 8848858
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5754) (10.090M) : 0, 10090148
master (10.054M) : 0, 10053618
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (5754) (6.748M) : 0, 6747593
master (6.652M) : 0, 6652460
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.361M) : 0, 7361092
section Manual
master (9.980M) : 0, 9980178
section Manual + Automatic
This PR (5754) (6.226M) : 0, 6225657
master (6.131M) : 0, 6130507
section DD_TRACE_ENABLED=0
master (9.497M) : 0, 9496505
|
Datadog ReportBranch report: ❌ 19 Failed (0 Known Flaky), 368202 Passed, 2074 Skipped, 15h 27m 56.19s Total Time ❌ Failed Tests (19)
|
Benchmarks Report for tracer 🐌Benchmarks for #5754 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 | 1.133 | 1,326.44 | 1,170.57 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.14μs | 0.722ns | 2.7ns | 0.0137 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.53μs | 0.792ns | 2.86ns | 0.0133 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.53μs | 1.42ns | 5.33ns | 0.158 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.33μs | 0.792ns | 2.97ns | 0.0132 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.64μs | 2.77ns | 10.3ns | 0.0141 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.63μs | 1.72ns | 6.67ns | 0.166 | 0 | 0 | 1.05 KB |
#5754 | CallElasticsearch |
net6.0 | 1.25μs | 1.56ns | 6.03ns | 0.0139 | 0 | 0 | 976 B |
#5754 | CallElasticsearch |
netcoreapp3.1 | 1.53μs | 0.919ns | 3.56ns | 0.013 | 0 | 0 | 976 B |
#5754 | CallElasticsearch |
net472 | 2.51μs | 1.09ns | 4.1ns | 0.158 | 0 | 0 | 995 B |
#5754 | CallElasticsearchAsync |
net6.0 | 1.17μs | 0.55ns | 2.13ns | 0.0135 | 0 | 0 | 952 B |
#5754 | CallElasticsearchAsync |
netcoreapp3.1 | 1.67μs | 4.37ns | 15.7ns | 0.014 | 0 | 0 | 1.02 KB |
#5754 | CallElasticsearchAsync |
net472 | 2.57μs | 1.01ns | 3.91ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.29μs | 0.716ns | 2.68ns | 0.0129 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.69μs | 0.385ns | 1.39ns | 0.0126 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.68μs | 0.982ns | 3.8ns | 0.145 | 0 | 0 | 915 B |
#5754 | ExecuteAsync |
net6.0 | 1.24μs | 0.741ns | 2.87ns | 0.0133 | 0 | 0 | 952 B |
#5754 | ExecuteAsync |
netcoreapp3.1 | 1.59μs | 0.727ns | 2.82ns | 0.0127 | 0 | 0 | 952 B |
#5754 | ExecuteAsync |
net472 | 1.83μs | 1.05ns | 4.06ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.12μs | 0.931ns | 3.48ns | 0.0309 | 0 | 0 | 2.22 KB |
master | SendAsync |
netcoreapp3.1 | 5.1μs | 1.31ns | 5.07ns | 0.038 | 0 | 0 | 2.76 KB |
master | SendAsync |
net472 | 7.8μs | 2.47ns | 9.55ns | 0.499 | 0 | 0 | 3.15 KB |
#5754 | SendAsync |
net6.0 | 4.2μs | 2.17ns | 8.12ns | 0.0315 | 0 | 0 | 2.22 KB |
#5754 | SendAsync |
netcoreapp3.1 | 5.08μs | 1.11ns | 3.85ns | 0.0355 | 0 | 0 | 2.76 KB |
#5754 | SendAsync |
net472 | 7.74μs | 1.59ns | 5.93ns | 0.496 | 0 | 0 | 3.15 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.54μs | 0.587ns | 2.2ns | 0.0231 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.21μs | 1.02ns | 3.69ns | 0.0221 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.56μs | 1.08ns | 4.19ns | 0.249 | 0 | 0 | 1.57 KB |
#5754 | EnrichedLog |
net6.0 | 1.49μs | 2.97ns | 11.5ns | 0.023 | 0 | 0 | 1.64 KB |
#5754 | EnrichedLog |
netcoreapp3.1 | 2.29μs | 2.88ns | 10.4ns | 0.0216 | 0 | 0 | 1.64 KB |
#5754 | EnrichedLog |
net472 | 2.58μs | 0.964ns | 3.61ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 114μs | 119ns | 462ns | 0.0573 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 118μs | 391ns | 1.51μs | 0.0585 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 146μs | 144ns | 558ns | 0.657 | 0.219 | 0 | 4.46 KB |
#5754 | EnrichedLog |
net6.0 | 114μs | 131ns | 506ns | 0.0578 | 0 | 0 | 4.28 KB |
#5754 | EnrichedLog |
netcoreapp3.1 | 118μs | 216ns | 837ns | 0.059 | 0 | 0 | 4.28 KB |
#5754 | EnrichedLog |
net472 | 146μs | 92.8ns | 347ns | 0.66 | 0.22 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.21μs | 0.952ns | 3.56ns | 0.0306 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.29μs | 2.09ns | 7.81ns | 0.03 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.75μs | 7.01ns | 26.2ns | 0.32 | 0 | 0 | 2.02 KB |
#5754 | EnrichedLog |
net6.0 | 2.98μs | 0.583ns | 2.1ns | 0.0299 | 0 | 0 | 2.2 KB |
#5754 | EnrichedLog |
netcoreapp3.1 | 4.21μs | 5.59ns | 21.6ns | 0.0294 | 0 | 0 | 2.2 KB |
#5754 | EnrichedLog |
net472 | 4.86μs | 1.26ns | 4.87ns | 0.319 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.37μs | 0.586ns | 2.27ns | 0.0165 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.77μs | 1.1ns | 4.26ns | 0.0159 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.04μs | 0.592ns | 2.29ns | 0.183 | 0 | 0 | 1.16 KB |
#5754 | SendReceive |
net6.0 | 1.28μs | 0.511ns | 1.91ns | 0.016 | 0 | 0 | 1.14 KB |
#5754 | SendReceive |
netcoreapp3.1 | 1.76μs | 0.781ns | 3.02ns | 0.015 | 0 | 0 | 1.14 KB |
#5754 | SendReceive |
net472 | 2.04μs | 1.2ns | 4.64ns | 0.184 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.86μs | 0.852ns | 3.19ns | 0.0228 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.05μs | 3.07ns | 11.9ns | 0.0223 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.44μs | 1.11ns | 4.15ns | 0.323 | 0 | 0 | 2.04 KB |
#5754 | EnrichedLog |
net6.0 | 2.73μs | 1.01ns | 3.8ns | 0.0218 | 0 | 0 | 1.6 KB |
#5754 | EnrichedLog |
netcoreapp3.1 | 3.96μs | 1.3ns | 5.02ns | 0.0217 | 0 | 0 | 1.65 KB |
#5754 | EnrichedLog |
net472 | 4.28μs | 1.32ns | 4.95ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 393ns | 0.255ns | 0.987ns | 0.00811 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 595ns | 0.253ns | 0.981ns | 0.00782 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 598ns | 0.889ns | 3.33ns | 0.0918 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 530ns | 0.321ns | 1.24ns | 0.00962 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 726ns | 0.969ns | 3.75ns | 0.00944 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 813ns | 0.917ns | 3.43ns | 0.104 | 0 | 0 | 658 B |
#5754 | StartFinishSpan |
net6.0 | 400ns | 0.233ns | 0.902ns | 0.00802 | 0 | 0 | 576 B |
#5754 | StartFinishSpan |
netcoreapp3.1 | 613ns | 0.628ns | 2.35ns | 0.00778 | 0 | 0 | 576 B |
#5754 | StartFinishSpan |
net472 | 638ns | 1.07ns | 4.15ns | 0.0915 | 0 | 0 | 578 B |
#5754 | StartFinishScope |
net6.0 | 478ns | 0.387ns | 1.5ns | 0.00972 | 0 | 0 | 696 B |
#5754 | StartFinishScope |
netcoreapp3.1 | 661ns | 0.742ns | 2.87ns | 0.00955 | 0 | 0 | 696 B |
#5754 | StartFinishScope |
net472 | 860ns | 0.332ns | 1.29ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 644ns | 0.341ns | 1.32ns | 0.00978 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 1E+03ns | 0.987ns | 3.82ns | 0.00962 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.12μs | 1.29ns | 4.99ns | 0.104 | 0 | 0 | 658 B |
#5754 | RunOnMethodBegin |
net6.0 | 641ns | 0.466ns | 1.8ns | 0.00965 | 0 | 0 | 696 B |
#5754 | RunOnMethodBegin |
netcoreapp3.1 | 973ns | 0.592ns | 2.29ns | 0.00917 | 0 | 0 | 696 B |
#5754 | RunOnMethodBegin |
net472 | 1.15μs | 0.992ns | 3.84ns | 0.104 | 0 | 0 | 658 B |
85453d3
to
1811997
Compare
1811997
to
db4c431
Compare
Summary of changes
Runs the
CallTargetNativeTests
on WindowsReason for change
We weren't running these on Windows, and we should be
Implementation details
Add the
RunOnWindows
trait. Longer term I want to reverse the role of this trait, i.e. we run on windows by default and you addRunOnWindows=False
to disable that.Test coverage
More now
Other details
I thought we had a bug related to ref structs here, but it appears to be a Schrödinger's bugOops, no, there it is!