Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IAST] Safeguard Method Replace aspects with try/catch (#5841 -> v2) #5855

Merged
merged 1 commit into from
Aug 7, 2024

Commits on Aug 7, 2024

  1. [IAST] Safeguard Method Replace aspects with try/catch (#5841)

    Covered all `AspectMethodReplace` aspects with try catch clauses to
    ensure no crash will bubble up to client, following new analyzer rules.
    
    Disabled some weird casts and processes to support some functions not
    present en NetCore 2.0, but present in 2.1 (netstandard2 assembly is
    loaded in netcore2.1 apps).
    
    Disabled some overloads receiving generic undefined arguments until
    proper callsite support is implemented.
    
    SSI will make the tracer enabled for a lot more of services when
    available. We must ensure we do not break any of them, and if so, that
    we provide a fast answer.
    
    Apply analyzer suggestions adding a try / catch clause in all
    `Methodreplace` aspects
    
    <!-- Fixes #{issue} -->
    
    <!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
    merging. Unless CODEOWNERS specifies otherwise, for external teams it is
    typically best to have one review from a team member, and one review
    from apm-dotnet. Trivial changes do not require 2 reviews. -->
    daniel-romano-DD committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d19f44f View commit details
    Browse the repository at this point in the history