Support for R2DBC #4673
Comments
|
OpenTelemetry also solves this using a ProxyConnectionFactory: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/r2dbc-1.0/library/README.md Hoping this can be added to dd-trace-java as well! |
|
Any chance there's an update on this? It'd be really nice to have r2dbc support in our DataDog traces, since the current behavior spawns a new trace id every time an r2dbc operation is performed. |
|
Do you have a workaround to avoid generating a new trace id each time ? I have the same issue. |
|
Any updates or work arounds for this issue? |
|
Hello 👋 Brian from Datadog here Unfortunately, there are no updates on R2DBC support at this time. That being said, we'll be sure to update this issue when we make progress |
Have you found any workaround? |
Not yet unfortunately. Still hoping for full support for r2dbc at this point 🤞 |
|
Hi - since 1.38.1 you can now add the OTel R2DBC instrumentation at runtime to For example: Open http://127.0.0.1:8080/products to exercise the product query - you should see R2DBC spans in the Datadog UI Note that we currently only support versions up to 2.5.0-alpha of the R2DBC instrumentation. This is because in 2.6.0-alpha OTel refactored some of the instrumentation config classes and we need to adjust our mappings to account for that. |
|
Hi I've implemented the solution suggested by @mcculls. However, I'm getting these errors.
and this:
Any ideas for solving these errors? Thank you. |
|
@geezylucas which OpenTelenetry jar did you download? Also can you list the exact command(s) you used and the version of |
|
dd-java-agent.jar: https://dtdg.co/latest-java-tracer I've been using a Docker (GKE) for deploy this API. and also I use flux (helm) to add these variables datadog: # Datadog APM config
enabled: true # Enable Datadog APM
labels: # Add required Datadog labels
tags.datadoghq.com/env: "qas" # Environment
tags.datadoghq.com/service: "service-name" # Application name
tags.datadoghq.com/version: "12" # Default to version 12
admission.datadoghq.com/enabled: "true" # Enable injection
annotations: # Add required Datadog annotations
admission.datadoghq.com/java-lib.version: "v1.35.2" # Tell the APM java version
env: # Insert environments vars inside pod
- name: DD_LOGS_INJECTION
value: "true"
- name: DD_ENV
valueFrom:
fieldRef:
fieldPath: metadata.labels['tags.datadoghq.com/env'] # Take values from labels
- name: DD_SERVICE
valueFrom:
fieldRef:
fieldPath: metadata.labels['tags.datadoghq.com/service'] # Take values from labels
- name: DD_VERSION
valueFrom:
fieldRef:
fieldPath: metadata.labels['tags.datadoghq.com/version'] # Take values from labelsfinally, I see this env variables
|
|
Hi @geezylucas - so far I can only recreate this exception when I use version 1.38.0 of I'm wondering whether a different Could you check which version is shown in the |
|
I see this version in
|
|
OK, that would explain it - the version of If the older version is coming in via i.e. put the newer version first, so it takes precedence Otherwise if the older version is being injected by single-step then you'd need to update the version in your single-step configuration. Hope that helps |
|
Thank you so much @mcculls Last question, I read this article https://docs.datadoghq.com/database_monitoring/connect_dbm_and_apm/?tab=java and I'm wondering if I can use your solution with OpenTelemetry (R2DBC) to correlate dbm and traces. |
R2DBC project reached 1.0 release and already has support for popular databases such as Oracle, PostgreSQL, MySQL, H2, MsSQL, and MariaDB. R2DBC provides a nice feature for observability as r2dbc-proxy. But anyway, it would be nice to have instrumentation out of the box.
https://r2dbc.io
The text was updated successfully, but these errors were encountered: