Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scanDependencies CLI #5474

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix scanDependencies CLI #5474

merged 1 commit into from
Jun 27, 2023

Conversation

smola
Copy link
Member

@smola smola commented Jun 27, 2023

What Does This Do

Motivation

Broken by previous class move.

Additional Notes

@smola
Fix scanDependencies CLI
d3418b8 
Broken by previous class move.
@smola smola requested a review from a team as a code owner June 27, 2023 08:24
@smola smola added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jun 27, 2023
bantonsson
bantonsson approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a red-face test to the test-published-depenencies?

@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.17.0-SNAPSHOT~974bf643b7 1.17.0-SNAPSHOT~d3418b8212
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

@smola smola enabled auto-merge (squash) June 27, 2023 09:21
@smola smola merged commit d5775d4 into master Jun 27, 2023
@smola smola deleted the smola/fix-scandependencies-cli branch June 27, 2023 09:40
@github-actions github-actions bot added this to the 1.16.3 milestone Jun 27, 2023
@smola smola modified the milestones: 1.16.3, 1.17.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderruiz anderruiz anderruiz approved these changes

@bantonsson bantonsson bantonsson approved these changes

Assignees
No one assigned
Labels
comp: telemetry Telemetry type: bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smola @bantonsson @anderruiz