Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing the units field from Label to conserve memory #204

Open
danielsn opened this issue Aug 8, 2023 · 1 comment
Open

Comments

@danielsn
Copy link
Contributor

danielsn commented Aug 8, 2023

          I actually wonder if we should get rid of the units and take the memory savings that come with that -- I'm not sure any of our profilers ever sets the units.

Originally posted by @ivoanjo in #202 (comment)

@ivoanjo
Copy link
Member

ivoanjo commented Aug 10, 2023

To add from the other thread, it looks only PHP is making use of this:

I did a quick check:

...ahaha but last and not least, php does seem to be using it.

But it may be worth discussing and seeing if we can agree to drop this from the API, so we can save some extra memory/overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants