Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the local ASM config in remote config scenarios with ASM_FEATURES #559

Closed
simon-id opened this issue Oct 11, 2022 · 2 comments · Fixed by #565
Closed

Remove the local ASM config in remote config scenarios with ASM_FEATURES #559

simon-id opened this issue Oct 11, 2022 · 2 comments · Fixed by #565
Assignees

Comments

@simon-id
Copy link
Member

simon-id commented Oct 11, 2022

According to the spec, the remote config AppSec 1 click activation feature should not be active when appsec has been locally configured. We need to remove any DD_APPSEC_ENABLED for those test to work as intended.

@ameske
Copy link
Contributor

ameske commented Oct 12, 2022

I think this is just as simple as making sure that's not set for our scenario, since we run the remote config scenarios independently of everything else. Disabling DD_APPSEC_ENABLED won't get in the way of other tests if that's the case.

@ameske ameske self-assigned this Oct 12, 2022
@ameske
Copy link
Contributor

ameske commented Oct 12, 2022

Addressed in #565 by b562c9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants