-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datasets: add unit tests #32
Comments
I've been interested in contributing to this project for a while! Is it ok if I take a shot at this issue? |
Hi @Magalame , any contribution large or small is very welcome ^^ |
Hi again! |
@Magalame how would you use hashing for this ? |
I think I misunderstood the purpose of the issue, I thought it was to check the integrity of the data |
Actually I think there is a reasonable way to use hashing for this. We basically want unit tests to make sure that the functions in So a nice way to do that would be, approximately, for each data set: do
abas <- getDataset abalone
head abas `shouldBe` valueOfHeadOfAbas
last abas `shouldBe` valueOfLastOfAbas
force (hash abas) `shouldBe` fixedHash and then the same for It would have the advantage of partly solving #29. And Haskell has a nice |
ping @ocramz |
Some unit tests asserting e.g. the length or some other property of the datasets would be nice to have.
The text was updated successfully, but these errors were encountered: